Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] attempt to fix number display issue of gradients #6925

Closed
wants to merge 1 commit into from

Conversation

donovaly
Copy link
Member

@donovaly donovaly commented May 28, 2022

Forum thread: https://forum.freecadweb.org/viewtopic.php?p=598019#p598019

  • depending on the length of label numbers and the main window size you cannot see the numbers
  • this PR improves the situation a bit since it adds more space for longer numbers

a proper solution would however be to take the width of the number label and perform the calculation with this result since one is then also independent on the window size

Here is the behavior with the PR:
FreeCAD_jUh8CnvjKI

As one can see not optimal. yet.

I put it on the milestone for 0.20 because I realized that on small laptop screens there is even with just 2 decimals there is not enough space to see the numbers. But then the gradient is useless. Since for Elmer simulations we don't provide another result visualization, we make the whole Elmer simulation feature rather useless for users with small screens (<= 15 inch).

@donovaly donovaly added this to the 0.20 milestone May 28, 2022
@donovaly donovaly requested a review from wwmayer May 28, 2022 02:51
@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label May 28, 2022
@freecadci
Copy link

pipeline status for feature branch PR_6925. Pipeline 550159958 was triggered at dd36dba. All CI branches and pipelines.

@donovaly donovaly marked this pull request as draft May 28, 2022 03:12
- depending on the length of label numbers and the main window size you cannot see the numbers
- this PR improves the situation a bit since it adds more space for longer numbers

a proper solution would however be to take the width of the number label and perform the calculation with this result since one is then also independent on the window size
@freecadci
Copy link

pipeline status for feature branch PR_6925. Pipeline 550166755 was triggered at 0daa85c. All CI branches and pipelines.

@wwmayer
Copy link
Contributor

wwmayer commented May 28, 2022

See #6927

@donovaly
Copy link
Member Author

Closing since this was just a try and #6927 is the proper intended fix

@donovaly donovaly closed this May 29, 2022
@donovaly donovaly removed this from the 0.20 milestone May 29, 2022
@donovaly donovaly deleted the Gui-fix-gradient branch June 5, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants