Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: Add support for editing profile type, add L and T sections #7217

Merged
merged 1 commit into from Jul 20, 2022

Conversation

manuvarkey
Copy link
Contributor

  1. Add support for changing profile type after addition. Allows selection of all profiles in presets while editing an already created profile. Fixes bug [Bug] cannot change type of profile after addition of profile using Arch Profile tool #6679 in the true sense.
  2. Add new profile type classes for L and T sections.
  3. Add IS Angle & IS Tee profile presets.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@github-actions github-actions bot added the WB Arch Related to the Arch Workbench label Jul 18, 2022
@manuvarkey
Copy link
Contributor Author

@yorikvanhavre

As per discussion on #7181.

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7217. Pipeline 590765586 was triggered at a0bea6b. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Excellent! Well done!

@yorikvanhavre yorikvanhavre merged commit e8fd473 into FreeCAD:master Jul 20, 2022
@donovaly
Copy link
Member

Many thanks for the new feature. Can you please describe it in the Wiki and the release notes?: https://forum.freecadweb.org/viewtopic.php?f=10&t=69438

if you have not yet a Wiki account, please create one and request write permissions here: https://forum.freecadweb.org/viewtopic.php?f=21&t=6830

If you cannot do this right now, please reply to this thread that it won't be forgotten: https://forum.freecadweb.org/viewtopic.php?f=10&t=69438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants