Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix alignment of angular dimension arrows #7453

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Sep 6, 2022

When calculating the alignment of the arrows the length of the arrows, in mm, was subtracted or added to a parameter in radians.

Additionally:

  • When updating the ArrowSize or ArrowType the updateData() function is now called. Without this the dimension would need to be recomputed to see the results.
  • Changed self.updateData(obj, "Start") to self.updateData(obj, None) since the function ignores the prop argument.
  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


@github-actions github-actions bot added the WB Draft Related to the Draft Workbench label Sep 6, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7453. Pipeline 632450934 was triggered at c5a79d3. All CI branches and pipelines.

The FlipArrows property for angular dimensions is handled differently.
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7453. Pipeline 633819521 was triggered at a71a062. All CI branches and pipelines.

@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 7, 2022

I have updated the PR to improve the alignment of flipped arrows. In the case of consecutive angular dimensions, flipped arrows should be coincident with neighboring non-flipped arrows.

@yorikvanhavre yorikvanhavre merged commit 220c8c1 into FreeCAD:master Sep 8, 2022
@Roy-043 Roy-043 deleted the Draft-Fix-alignment-of-angular-dimension-arrows branch September 8, 2022 10:32
@donovaly
Copy link
Member

Is this something that could/should be backported? @Roy-043

@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 12, 2022

This can be backported.

@donovaly
Copy link
Member

Thanks, backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants