Gui: overlay dock widgets user interface #7888

realthunder · 2022-11-27T22:58:20Z

Forum thread https://forum.freecadweb.org/viewtopic.php?f=34&t=73280

freecadci · 2022-11-27T23:07:06Z

for feature branch PR_7888. Pipeline 706385033 was triggered at 7cf7aac. All CI branches and pipelines.

freecadci · 2022-11-28T11:27:59Z

for feature branch PR_7888. Pipeline 706832222 was triggered at 9bd4415. All CI branches and pipelines.

adrianinsaval · 2022-11-28T22:24:00Z

I'll try to give a more detailed report later or during the week but it is behaving very buggy for me right now, for starters it's not really transparent for me

And I can't manage to resize the panels to show for example teh property view and tree view at the same time one above the other or the python console and report view one besides the other.

Generating test builds for FreeCAD/FreeCAD#7888

luzpaz · 2022-11-28T23:02:14Z

Snap test package being generated. Watch this space for updates

Edit: build available (until retriggered if new commits are made to this PR) at FreeCAD/FreeCAD-snap#72 (comment)

Edit2: updated ☝️

chennes

I've only looked at the code for the first four commits so far, but it looks very good. I've left a few small comments, nothing blocking a merge if you don't get to them. I love the changes to Parameter, thanks for doing that.

chennes · 2022-11-29T03:27:19Z

src/Gui/PrefWidgets.cpp

+  switch(static_cast<int>(getParamType())) {
+  case QMetaType::Int:
+  case QMetaType::LongLong:
+    index = findData((int)getWindowParameter()->GetInt(entryName(), m_Default.toInt()));


Looks like a couple stray C-style casts are floating around in here.

chennes · 2022-11-29T03:34:50Z

src/Base/Parameter.cpp

+    case FCGroup:
+        return "FCParamGroup";
+    default:
+        return 0;


I think some static analyzers are going to flag this: consider nullptr (or throw something).

chennes · 2022-11-29T03:36:42Z

src/Base/Parameter.cpp

+                    pcTemp)->getAttributes()->getNamedItem(
+                        XStr("Name").unicodeForm())->getNodeValue()).c_str();
+        // check on filter condition
+        if (sFilter == NULL || Name.find(sFilter)!= std::string::npos) {


NULL -> nullptr

chennes · 2022-11-29T03:40:57Z

src/Base/Parameter.h

+
+    /** @name methods for generic attribute handling */
+    //@{
+    enum ParamType {


Any reason not to use a class enum?

chennes · 2022-11-29T05:42:56Z

@realthunder I am getting a strange multiply-defined-symbol error when I compile on Windows:

Error	LNK2005	"public: virtual __cdecl Base::Observer<char const *>::~Observer<char const *>(void)" (??1?$Observer@PEBD@Base@@UEAA@XZ) already defined in EditModeCoinManager.obj	SketcherGui	E:\FreeCAD\FreeCAD-build\src\Mod\Sketcher\Gui\FreeCADGui.lib(FreeCADGui.dll)	1

Any idea what's causing this?

realthunder · 2022-11-29T13:36:48Z

@chennes Commit added for a fix. Please try. I've also made some code changes according to your suggestion.

freecadci · 2022-11-29T13:43:13Z

for feature branch PR_7888. Pipeline 708120807 was triggered at 4de2174. All CI branches and pipelines.

chennes · 2022-11-29T14:33:16Z

@chennes Commit added for a fix. Please try. I've also made some code changes according to your suggestion.

Thanks, Windows build compiles now.

luzpaz · 2022-11-29T14:50:28Z

Retriggering Snap build

Edit: Done. New snap available.

chennes · 2022-12-03T05:11:09Z

I think the first five commits here are obviously improvements, and can be (uncontroversially) merged. So I propose to cherry-pick those commits, so that the remainder of the review can focus on the more exciting things in this PR. That's:

[Base/App: add new signal interface to Parameter] 2c9b560
[Tools: add utility script for code generation using cog] 4b8ed4d
[Gui: split out TreeParams into its own source files] d27748c
[Gui: support more parameter types in PrefComboBox] 6d3a574
[Gui: fix transparency saving in PrefColorButton] e0da4c0

plus the final new commit,

[Base: fix Windows build issue] 4de2174

@realthunder any objection to this? Obviously you'll have to rebase afterwards.

realthunder · 2022-12-03T05:13:34Z

That's great! Thanks @chennes

chennes · 2022-12-03T20:26:25Z

The cherry-pick is failing because that set of commits won't compile on its own (at least on MSVC): I'm missing a definition for Gui::TreeWidget::setIconHeight -- where can I find that?

realthunder · 2022-12-03T22:15:55Z

Please comment out the setIconHeight() call inside TreeParams::onIconSizeChanged(), in TreeParams.cpp. I'll add it back when I rebase.

chennes · 2022-12-03T23:14:22Z

OK, those six commits I mentioned above were cherry-picked -- I had to rebase before committing, so the hashes will be different. I also added 848e6cc to comment out those two problematic lines.

chennes

Another round of comments below, focusing entirely on the code in commit 998afb8. I did not complete my review of OverlayWidgets.* due to their size. I'll return to it once some documentation is in place.

chennes · 2022-12-04T00:18:05Z

src/Gui/ComboView.cpp

+        if(!prop)
+            prop = new PropertyView(this);
+
+        modelIndex = tabs->insertTab(0, splitter,trUtf8("Model"));


Isn't trUtf8 the Qt4 way of doing it? As of Qt5 everything is UTF-8, right?

chennes · 2022-12-04T00:23:21Z

src/Gui/ComboView.h

+    Gui::PropertyView                  * prop = nullptr;
+    Gui::TreePanel                     * tree = nullptr;
+    Gui::TaskView::TaskView            * taskPanel = nullptr;


These are owned by this class, right? Now might be a good opportunity to make them unique_ptr.

chennes · 2022-12-04T00:43:54Z

src/Gui/CommandView.cpp

+  sGroup        = "View";
+  sMenuText     = QT_TR_NOOP("Toggle transparent for all");
+  sToolTipText  = QT_TR_NOOP("Toggle transparent for all overlay docked window.\n"
+                             "This makes the docked widget stay transparent at al times.");


chennes · 2022-12-04T00:44:31Z

src/Gui/CommandView.cpp

+    sGroup        = "Standard-View";
+    sMenuText     = QT_TR_NOOP("Toggle transparent");
+    sToolTipText  = QT_TR_NOOP("Toggle transparent mode for the docked widget under cursor.\n"
+                               "This makes the docked widget stay transparent at al times.");


chennes · 2022-12-04T00:49:48Z

src/Gui/DockWindowManager.cpp

+        if (static_cast<QMouseEvent*>(e)->buttons() != Qt::NoButton)
+            return false;
+        auto pos = QCursor::pos();
+        const int m = 5;


IMO m is not descriptive enough a name for this variable, especially since it looks like a magic number. Does this behave on high-DPI displays? I'm not a big fan of hardcoding this here.

chennes · 2022-12-04T01:51:47Z

src/Gui/OverlayWidgets.cpp

+        drawLine = false;
+        update();
+    }
+    return hit;


It doesn't look like client code ever actually uses this return value (which is a bool, despite hit being an int?!).

chennes · 2022-12-04T01:53:31Z

src/Gui/OverlayWidgets.cpp

+    // This is necessary to capture any focus lost from switching the tab,
+    // otherwise the lost focus will leak to the parent, i.e. MdiArea, which may
+    // cause unexpected Mdi sub window switching.
+    // setFocusPolicy(Qt::StrongFocus);


If the comment is true, why is this line commented out?

chennes · 2022-12-04T01:57:38Z

src/Gui/OverlayWidgets.h

+    void retranslate();
+    void refreshIcons();
+
+    enum ReloadMode {


Probably modernize all of these enums to class enums.

chennes · 2022-12-04T02:00:14Z

src/Gui/OverlayWidgets.h

+    void initDockWidget(QDockWidget *, QWidget *);
+    void setupDockWidget(QDockWidget *, int dockArea = Qt::NoDockWidgetArea);
+    void unsetupDockWidget(QDockWidget *);


Without any comments it's hard to tell what these actually do -- what is the difference between "init" and "setup"? Overall I think this file, and the individual classes in it, are too long, too complex, and lack documentation. The first two problems we can work on over time, but only if there is documentation to get started.

chennes · 2022-12-04T02:08:06Z

src/Gui/Tree.cpp

+    if(ti->type()!=TreeWidget::ObjectType || index.column()>1)
+        return 0;
+    DocumentObjectItem *item = static_cast<DocumentObjectItem*>(ti);
+    App::DocumentObject *obj = item->object()->getObject();
+    auto &prop = index.column()?obj->Label2:obj->Label;


Looks like mistakenly-included code that overwrites some formatting improvements.

freecadci · 2022-12-11T12:38:54Z

for feature branch PR_7888. Pipeline 719160026 was triggered at ae2f789. All CI branches and pipelines.

freecadci · 2022-12-11T12:43:00Z

for feature branch PR_7888. Pipeline 719160783 was triggered at 367f75f. All CI branches and pipelines.

freecadci · 2022-12-11T14:49:07Z

for feature branch PR_7888. Pipeline 719194144 was triggered at ebc6c08. All CI branches and pipelines.

realthunder · 2022-12-12T02:54:34Z

@chennes I've modified and rebase the code according to suggestions. Please check.

adrianinsaval · 2023-10-09T20:10:48Z

I add my vote to merging and then fixing problems one by one in subsequent PRs, even in it's current state I found using this VERY useful

PaddleStroke · 2023-10-10T07:07:02Z

Bump for #include <QDesktopWidget> header issue that needs to be fixed @realthunder.
I think the problem is because the header is missing from PreCompiled.h.

@chennes if RT is out for now, maybe we can just fix the precompiled in another PR that we merge first and merge this?

PaddleStroke · 2023-10-10T07:14:22Z

I strongly suggest that we merge this asap, if we don't here's whats going to happen :

A random clang format PR or modernize PR or typo PR is going to make a small conflict.
By the time RT comes around there will be a lot of conflicts, which will demotivate RT from rebasing again. So it will take a lot of time until he does and so on.

One tiny typo PR landing on this massive PR (which I'm surprised hasn't happened yet) and we're in for 2 months. And if it happens once, no reason it won't repeat -> rebasing hell and it will never merge.

0penBrain · 2023-10-10T09:59:18Z

Bump for #include <QDesktopWidget> header issue that needs to be fixed @realthunder. I think the problem is because the header is missing from PreCompiled.h.

@chennes if RT is out for now, maybe we can just fix the precompiled in another PR that we merge first and merge this?

Another PR isn't needed. Branch is open to maintainer edit.

yorikvanhavre · 2023-10-11T07:50:34Z

Another PR isn't needed. Branch is open to maintainer edit.

I can't edit a file that is not included in this PR apparently... I'll try to do it locally but not sure I'll be able to push to @realthunder 's repo.

EDIT

I can't:

To github.com:realthunder/FreeCAD.git
! [remote rejected]       realthunder-OverlayWidgets -> OverLayWidgets (permission denied)
error: failed to push some refs to 'github.com:realthunder/FreeCAD.git'

Ok let's merge this and I'll add the fix right after

luzpaz · 2023-10-11T12:55:21Z

Huge congrats to everyone!!!

wwmayer · 2023-10-11T15:53:07Z

    // We are migrating from saving qt main window layout state in QSettings to
    // FreeCAD parameters, for more control. The old settings is explicitly
    // remove from old QSettings conf to allow easier complete reset of
    // application state by just removing FC user.cfg file.
    config.remove(qtver);

I wonder what's the point of removing settings here. Every time a user starts the new version the settings will be removed so that when using an older version all layout settings are completely gone. This is very annoying behaviour!

Furthermore I wonder what is the more control you are talking about? The QSettings class was only used to store the size, position, maximized or not, layout of toolbars and dock windows and the visibility of the status bar because (except of the maximized flag and the status bar) these are system-related settings and haven't been added to the user.cfg on purpose.

Having all these things in the user.cfg doesn't have any advantage but will sooner or later cause trouble for people who wants to use their user.cfg on different computers.

obelisk79 · 2023-10-11T16:09:39Z

It may allow for additional control via distributed preference packs perhaps? This would include saving and importing these parameters via the same mechanism I believe. Just my speculation.

MisterMakerNL · 2023-10-11T17:43:22Z

Already cleaned and polished the overlay qss a bit #11005

wwmayer · 2023-10-11T21:21:54Z

It may allow for additional control via distributed preference packs perhaps?

I doubt that having junk like this in the user.cfg is of any help:

          <FCText Name="MainWindowState">AAAA/wAAAAD9AAAAAwAAAAAAAAG6AAADkPwCAAAAIfsAAAAcAFMAZQBsAGUAYwB0AGkAbwBuACAAdgBpAGUAdwAAAABkAAAAwQAAAIkA////+wAAABQAQwBvAG0AYgBvACAAVgBpAGUAdwEAAABkAAADfQAAAAAAAAAA+wAAABAAQwBsAGkAcABwAGkAbgBnAQAAAh0AAAHXAAAAAAAAAAD7AAAAHABTAGUAbABlAGMAdABpAG8AbgAgAHYAaQBlAHcAAAAAAP////8AAAAAAAAAAPsAAAAUAEMAbwBtAGIAbwAgAFYAaQBlAHcBAAAAPQAAA7cAAAAAAAAAAPsAAAAcAFMAZQBsAGUAYwB0AGkAbwBuACAAdgBpAGUAdwAAAAAA/////wAAAAAAAAAA+wAAABQAQwBvAG0AYgBvACAAVgBpAGUAdwEAAAA9AAADtwAAAAAAAAAA+wAAABwAUwBlAGwAZQBjAHQAaQBvAG4AIAB2AGkAZQB3AAAAAAD/////AAAAAAAAAAD7AAAAFABDAG8AbQBiAG8AIABWAGkAZQB3AQAAAD0AAAO3AAAAAAAAAAD7AAAAHABTAGUAbABlAGMAdABpAG8AbgAgAHYAaQBlAHcAAAAAAP////8AAAAAAAAAAPsAAAAUAEMAbwBtAGIAbwAgAFYAaQBlAHcBAAAAPQAAA7cAAAAAAAAAAPsAAAAQAEMAbABpAHAAcABpAG4AZwEAAAITAAAB1wAAAAAAAAAA+wAAABAAQwBsAGkAcABwAGkAbgBnAQAAAhMAAAHXAAAAAAAAAAD7AAAAEABDAGwAaQBwAHAAaQBuAGcBAAACEwAAAdcAAAAAAAAAAPwAAABkAAADfQAAAAAA////+gAAAAABAAAAAfsAAAASAFQAcgBlAGUAIAB2AGkAZQB3AQAAAAAAAAHjAAAAAAAAAAD7AAAAGgBQAHIAbwBwAGUAcgB0AHkAIAB2AGkAZQB3AQAAA0oAAACXAAAAAAAAAAD7AAAAHABTAGUAbABlAGMAdABpAG8AbgAgAHYAaQBlAHcAAAAAAP////8AAAAAAAAAAPsAAAAUAEMAbwBtAGIAbwAgAFYAaQBlAHcAAAACZwAAAYMAAAAAAAAAAPsAAAASAFQAcgBlAGUAIAB2AGkAZQB3AQAAAD0AAAHDAAAAAAAAAAD7AAAAGgBQAHIAbwBwAGUAcgB0AHkAIAB2AGkAZQB3AQAAAgYAAAHkAAAAAAAAAAD7AAAAHABTAGUAbABlAGMAdABpAG8AbgAgAHYAaQBlAHcAAAAAAP////8AAAAAAAAAAPsAAAAUAEMAbwBtAGIAbwAgAFYAaQBlAHcAAAAAAP////8AAAAAAAAAAPsAAAAcAFMAZQBsAGUAYwB0AGkAbwBuACAAdgBpAGUAdwAAAAAA/////wAAAAAAAAAA+wAAABQAQwBvAG0AYgBvACAAVgBpAGUAdwEAAABkAAADhgAAAAAAAAAA+wAAABwAUwBlAGwAZQBjAHQAaQBvAG4AIAB2AGkAZQB3AAAAAAD/////AAAAAAAAAAD7AAAAFABDAG8AbQBiAG8AIABWAGkAZQB3AQAAAD0AAAOtAAAAAAAAAAD7AAAAHABTAGUAbABlAGMAdABpAG8AbgAgAHYAaQBlAHcAAAAAAP////8AAAAAAAAAAPsAAAAUAEMAbwBtAGIAbwAgAFYAaQBlAHcBAAAAPQAAA60AAAAAAAAAAPsAAAAcAFMAZQBsAGUAYwB0AGkAbwBuACAAdgBpAGUAdwAAAAAA/////wAAAAAAAAAA+wAAABQAQwBvAG0AYgBvACAAVgBpAGUAdwEAAAA9AAADrQAAAAAAAAAA+wAAABwAUwBlAGwAZQBjAHQAaQBvAG4AIAB2AGkAZQB3AAAAAAD/////AAAAAAAAAAD7AAAAFABDAG8AbQBiAG8AIABWAGkAZQB3AQAAAF4AAAOMAAAAAAAAAAD8AAAAZAAAA5AAAADhAQAAHPoAAAABAgAAAAL7AAAACgBNAG8AZABlAGwBAAAAAP////8AAADEAP////sAAAAKAFQAYQBzAGsAcwEAAAAA/////wAAAFkA////AAAAAQAAAVgAAAOQ/AIAAAAw+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA5AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOQAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADkAAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA5AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOQAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADkAAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA5AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOQAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADkAAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA5AAAAAAAAAAAPsAAAAsAEUAdgBhAGwAdQBhAHQAZQAgACYAIABSAGUAcABhAGkAcgAgAE0AZQBzAGgBAAAAZAAAA5AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOQAAAAAAAAAAD7AAAALABFAHYAYQBsAHUAYQB0AGUAIAAmACAAUgBlAHAAYQBpAHIAIABNAGUAcwBoAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADgAAAAAAAAAAA+wAAABgAVABvAG8AbABTAGUAbABlAGMAdABvAHIBAAAAZAAAA4YAAAAAAAAAAPsAAAAsAEUAdgBhAGwAdQBhAHQAZQAgACYAIABSAGUAcABhAGkAcgAgAE0AZQBzAGgBAAAAZAAAA4YAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAD0AAAOtAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADgAAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADhgAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4YAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADhgAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4YAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADhgAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4YAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADhgAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4YAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADhgAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4YAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADgAAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOGAAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADgAAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA4AAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAOAAAAAAAAAAAD7AAAAHgBUAHIAZQBlACAAdgBpAGUAdwAgACgATQBWAEMAKQEAAABkAAADhgAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA3cAAAAAAAAAAPsAAAAeAFMAZQBjAHQAaQBvAG4AIABDAHUAdAB0AGkAbgBnAQAAAGQAAAN3AAAAAAAAAAD7AAAALABFAHYAYQBsAHUAYQB0AGUAIAAmACAAUgBlAHAAYQBpAHIAIABNAGUAcwBoAQAAAGQAAAN9AAAAAAAAAAD7AAAAHgBTAGUAYwB0AGkAbwBuACAAQwB1AHQAdABpAG4AZwEAAABkAAADdwAAAAAAAAAA+wAAAB4AUwBlAGMAdABpAG8AbgAgAEMAdQB0AHQAaQBuAGcBAAAAZAAAA30AAAAAAAAAAPsAAAAQAEQAQQBHACAAVgBpAGUAdwEAAABkAAADkAAAAGsA////AAAAAwAACgAAAAEa/AEAAAAP+wAAABYAUgBlAHAAbwByAHQAIAB2AGkAZQB3AQAAAAAAAAUWAAAARgD////7AAAAHABQAHkAdABoAG8AbgAgAGMAbwBuAHMAbwBsAGUBAAAFHAAABOQAAABGAP////sAAAAgAEQAbwB3AG4AbABvAGEAZAAgAE0AYQBuAGEAZwBlAHIBAAAIywAAATUAAAAAAAAAAPsAAAAcAFAAeQB0AGgAbwBuACAAYwBvAG4AcwBvAGwAZQEAAAWiAAAEXgAAAAAAAAAA+wAAABwAUAB5AHQAaABvAG4AIABjAG8AbgBzAG8AbABlAQAACRgAAADoAAAAAAAAAAD7AAAAHABQAHkAdABoAG8AbgAgAGMAbwBuAHMAbwBsAGUBAAAFOgAABMYAAAAAAAAAAPsAAAAcAFAAeQB0AGgAbwBuACAAYwBvAG4AcwBvAGwAZQEAAAUTAAAE7QAAAAAAAAAA+wAAABwAUAB5AHQAaABvAG4AIABjAG8AbgBzAG8AbABlAQAABpQAAANsAAAAAAAAAAD7AAAAHABQAHkAdABoAG8AbgAgAGMAbwBuAHMAbwBsAGUBAAAFKQAABNcAAAAAAAAAAPsAAAAgAEQAbwB3AG4AbABvAGEAZAAgAE0AYQBuAGEAZwBlAHIBAAAIxgAAAToAAAAAAAAAAPsAAAAcAFAAeQB0AGgAbwBuACAAYwBvAG4AcwBvAGwAZQEAAAZEAAADvAAAAAAAAAAA+wAAABwAUAB5AHQAaABvAG4AIABjAG8AbgBzAG8AbABlAQAACRgAAADoAAAAAAAAAAD7AAAAHABQAHkAdABoAG8AbgAgAGMAbwBuAHMAbwBsAGUBAAAJGAAAAOgAAAAAAAAAAPsAAAAcAFAAeQB0AGgAbwBuACAAYwBvAG4AcwBvAGwAZQEAAAkYAAAA6AAAAAAAAAAA+wAAABwAUAB5AHQAaABvAG4AIABjAG8AbgBzAG8AbABlAQAACRgAAADoAAAAAAAAAAAAAAbiAAADkAAAAAQAAAAEAAAACAAAAAj8AAAAGAAAAAEAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAAAAAACAAAAAAAAAAIAAAAAAAAAAgAAAAYAAAAIAEYAaQBsAGUBAAAAAP////8AAAAAAAAAAAAAAAgARQBkAGkAdAEAAABz/////wAAAAAAAAAAAAAAEgBDAGwAaQBwAGIAbwBhAHIAZAEAAAEF/////wAAAAAAAAAAAAAAEgBXAG8AcgBrAGIAZQBuAGMAaAEAAAF4/////wAAAAAAAAAAAAAACABIAGUAbABwAQAAAi3/////AAAAAAAAAAAAAAAIAFYAaQBlAHcBAAACXv////8AAAAAAAAAAAAAAAIAAAAJAAAAEgBTAHQAcgB1AGMAdAB1AHIAZQEAAAAA/////wAAAAAAAAAAAAAAJABQAGEAcgB0ACAARABlAHMAaQBnAG4AIABIAGUAbABwAGUAcgEAAAB//////wAAAAAAAAAAAAAAKABQAGEAcgB0ACAARABlAHMAaQBnAG4AIABNAG8AZABlAGwAaQBuAGcBAAACIv////8AAAAAAAAAAAAAAA4ATQBlAGEAcwB1AHIAZQEAAAU8/////wAAAAAAAAAAAAAADgBDAHUAcwB0AG8AbQAxAQAABjr/////AAAAAAAAAAAAAAAuAFAAYQByAHQALQBvAC0ATQBhAGcAaQBjACAAUABhAHIAdABEAGUAcwBpAGcAbgEAAAZr/////wAAAAAAAAAAAAAAEgBTAGUAYQByAGMAaABCAGEAcgEAAAZ8/////wAAAAAAAAAAAAAACgBNAGEAYwByAG8AAAAAAP////8AAAAAAAAAAAAAACwAUABhAHIAdAAtAG8ALQBNAGEAZwBpAGMAIABnAGwAbwBiAGEAbAAgAHYAMwAAAAAA/////wAAAAAAAAAA</FCText>

Also, when starting an older version after customizing the layout in the new version then the whole layout will be reverted. Another point is that these data depend on the used Qt version and therefore it makes no sense to share them between different FreeCAD versions that link different Qt versions. These are the reasons why in the past the layout data was written to the registry or FreeCAD.conf file, respectively and not into the user.cfg.

obelisk79 · 2023-10-11T22:13:19Z

perhaps @realthunder can speak to that and its purpose?

adrianinsaval · 2023-10-11T23:20:00Z

I can't speak about what purpose that serves for this PR but storing all that in user cfg file may make it much easier to get rid of some nasty bugs related to window and toolbar positions by just running a clean config. Some of these bugs could even prevent freecad from starting on windows for some people.

adrianinsaval · 2023-10-13T01:21:43Z

this initially worked fine but now in latest master I get this error in report view and the transparency doesn't work as expected:

QString::arg: Argument missing: overlay:%s, Dark-Outline.qss

kadet1090 · 2023-10-13T06:23:35Z

It must be due to this: #11012 - I'll check what is wrong and provide fix

wwmayer · 2023-10-13T06:34:26Z

It's this line: overlayStyleSheet = QStringLiteral("overlay:%s").arg(overlayStyleSheet);
%s must be replaced with %1

kadet1090 · 2023-10-13T06:37:47Z

Can you provide the fix? I won't be able to do that in 12 hours or so

wwmayer · 2023-10-13T06:40:26Z

#11021

maxwxyz · 2023-12-12T20:33:57Z

Some features do not automatically open the task dialog when set to Auto show on edit #11637
Not sure if this is a general issue or if this need to be tackled by the individual features?

luzpaz · 2023-12-21T20:40:41Z

Follow-up bugs to this PR:

maxwxyz · 2024-04-07T06:56:08Z

@luzpaz / all: to add

…|320px]] | добавлена функция, позволяющая накладывать прикрепляемые виджеты (дерево и прозрачность задач). [FreeCAD/FreeCAD#7888 Pull request #7888] |}"

github-actions bot added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: TechDraw Related to the TechDraw Workbench labels Nov 27, 2022

luzpaz added the Topic: User Interface Issue related UI / UX label Nov 28, 2022

realthunder force-pushed the OverlayWidgets branch from 7cf7aac to 9bd4415 Compare November 28, 2022 11:19

luzpaz added a commit to luzpaz/FreeCAD-snap that referenced this pull request Nov 28, 2022

Test build: Overlay doc widgets (realthunder)

41941d6

Generating test builds for FreeCAD/FreeCAD#7888

luzpaz mentioned this pull request Nov 28, 2022

Test build: Overlay doc widgets (realthunder) FreeCAD/FreeCAD-snap#72

Closed

chennes reviewed Nov 29, 2022

View reviewed changes

realthunder force-pushed the OverlayWidgets branch from 9bd4415 to 4de2174 Compare November 29, 2022 13:35

chennes reviewed Dec 4, 2022

View reviewed changes

realthunder force-pushed the OverlayWidgets branch 2 times, most recently from ae2f789 to 367f75f Compare December 11, 2022 12:33

realthunder force-pushed the OverlayWidgets branch from 367f75f to ebc6c08 Compare December 11, 2022 14:41

yorikvanhavre merged commit 21e6e7a into FreeCAD:main Oct 11, 2023

yorikvanhavre added a commit to yorikvanhavre/FreeCAD that referenced this pull request Oct 11, 2023

Added include missing from FreeCAD#7888

0af43b1

yorikvanhavre mentioned this pull request Oct 11, 2023

[HOLD] Added include missing from #7888 #10993

Closed

kadet1090 mentioned this pull request Oct 11, 2023

[Gui] Prefer Dark-Outline as default overlay stylesheet - #7888 #10994

Closed

This was referenced Oct 11, 2023

[Problem] Huge size of the preferences dialog #11004

Closed

Gui: fixes OverlayManager issues #11000

Merged

PaddleStroke mentioned this pull request Oct 12, 2023

[Overlay] 'Auto Task' not ideal #11013

Open

2 tasks

adrianinsaval mentioned this pull request Oct 17, 2023

[Overlay] 'Auto Mouse Wheel pass through' doesn't work on techdraw #11015

Closed

2 tasks

Gui: overlay dock widgets user interface #7888

Gui: overlay dock widgets user interface #7888

Conversation

realthunder commented Nov 27, 2022

freecadci commented Nov 27, 2022

freecadci commented Nov 28, 2022

adrianinsaval commented Nov 28, 2022 • edited Loading

luzpaz commented Nov 28, 2022 • edited Loading

chennes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chennes commented Nov 29, 2022

realthunder commented Nov 29, 2022

freecadci commented Nov 29, 2022

chennes commented Nov 29, 2022

luzpaz commented Nov 29, 2022 • edited Loading

chennes commented Dec 3, 2022

realthunder commented Dec 3, 2022

chennes commented Dec 3, 2022

realthunder commented Dec 3, 2022 • edited Loading

chennes commented Dec 3, 2022

chennes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

freecadci commented Dec 11, 2022

freecadci commented Dec 11, 2022

freecadci commented Dec 11, 2022

realthunder commented Dec 12, 2022

adrianinsaval commented Oct 9, 2023

PaddleStroke commented Oct 10, 2023

PaddleStroke commented Oct 10, 2023 • edited Loading

0penBrain commented Oct 10, 2023

yorikvanhavre commented Oct 11, 2023 • edited Loading

luzpaz commented Oct 11, 2023

wwmayer commented Oct 11, 2023

obelisk79 commented Oct 11, 2023

MisterMakerNL commented Oct 11, 2023

wwmayer commented Oct 11, 2023

obelisk79 commented Oct 11, 2023

adrianinsaval commented Oct 11, 2023

adrianinsaval commented Oct 13, 2023

kadet1090 commented Oct 13, 2023

wwmayer commented Oct 13, 2023

kadet1090 commented Oct 13, 2023

wwmayer commented Oct 13, 2023

maxwxyz commented Dec 12, 2023

luzpaz commented Dec 21, 2023 • edited Loading

maxwxyz commented Apr 7, 2024

adrianinsaval commented Nov 28, 2022 •

edited

Loading

luzpaz commented Nov 28, 2022 •

edited

Loading

luzpaz commented Nov 29, 2022 •

edited

Loading

realthunder commented Dec 3, 2022 •

edited

Loading

PaddleStroke commented Oct 10, 2023 •

edited

Loading

yorikvanhavre commented Oct 11, 2023 •

edited

Loading

luzpaz commented Dec 21, 2023 •

edited

Loading