Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined custom function (setpropertyRebarShape) in the _ViewProviderRebar class #822

Closed
wants to merge 5 commits into from

Conversation

@amrit3701
Copy link
Member

commented Jun 16, 2017

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR once it is merged.


setpropertyRebarShape(): This function will add properties to the instance of _ViewProviderRebar class as per according to the rebar shape.

@yorikvanhavre

This comment has been minimized.

Copy link
Member

commented Jun 19, 2017

Duplicating here what I wrote on IRC:

I don't understand what the setpropertyRebarShape() is for? I think these additional properties you are giving there should either become standard to all rebars (means, they should be added inside the rebar object's init function, or in your specific rebar script (you can create the rebar object, then add properties to it).

Besides, they are not visual properties, they influence the shape, so they should go to the object, not the view provider

@amrit3701

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2017

You may close this PR. As you said I have added all the properties in the rebar scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.