Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Defined custom function (setpropertyRebarShape) in the _ViewProviderRebar class #822
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
And please remember to update the Wiki with the features added or changed once this PR once it is merged.
setpropertyRebarShape(): This function will add properties to the instance of _ViewProviderRebar class as per according to the rebar shape.
Duplicating here what I wrote on IRC:
I don't understand what the setpropertyRebarShape() is for? I think these additional properties you are giving there should either become standard to all rebars (means, they should be added inside the rebar object's init function, or in your specific rebar script (you can create the rebar object, then add properties to it).
Besides, they are not visual properties, they influence the shape, so they should go to the object, not the view provider