Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcs links #916

Closed
wants to merge 32 commits into from
Closed

Xcs links #916

wants to merge 32 commits into from

Conversation

ickby
Copy link
Contributor

@ickby ickby commented Aug 6, 2017

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR once it is merged.


This pull request further details and implements the GeoFeatureGroup datastructure in FreeCAD:

  • PR introduces "scopes" to links to decide where they are allowed to go to in respect to GeoFeatureGroup
  • "out of scope" links are now reportet as error during recompute
  • Special scoped link properties are created
  • Multiple bugs with groups and geofeaturegroups are fixed
  • Backlink structure is fixed and reenabled to improve performance of many group operations

This is the first feature that used GeoFeatureGroupExtension and required links to the groups inside as well as to things on the same level. Hence a few modifications to link scopes have been nesseccary.
@sasobadovinac
Copy link
Contributor

does this only need to be reviewed or is there also something else preventing it from getting merged?

@peterlama
Copy link
Contributor

Have a look at the forum thread: https://www.forum.freecadweb.org/viewtopic.php?f=10&t=20749&start=30#p187270

@wwmayer
Copy link
Contributor

wwmayer commented Sep 9, 2017

Merged.

@wwmayer wwmayer closed this Sep 9, 2017
easyw added a commit to easyw/kicadStepUpMod that referenced this pull request Sep 18, 2017
fixed App::Part list inverted after FC 12090
FreeCAD/FreeCAD#916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants