New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks command improvement #83

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@abhisekp
Member

abhisekp commented Apr 16, 2016

Improved thanks command implementation

- **Using `lodash` for better performance due to lazy evaluation** - **Discards non-existing users and self while thanking and thank only existing ones** (which also fixes thanking `@/all` as a bonus) i.e. if a user doesn't exist in gitter, then there will be no API calls to thank that user.

Command

thanks @camperbot @/all @all @belindarogers

Bot Response

@abhisekp sends brownie points to @camperbot and @belindarogers ✨ πŸ‘ ✨
⚠️ could not find receiver for belindarogers
⭐️ 1560 | @camperbot | http://www.freecodecamp.com/camperbot

  • Improved bot response about giving brownie points

OLD

abhisekp sends brownie points to @rphares and @qmikew1 and @dwd2010 and @camperbot and @csegate2 ✨ πŸ‘ ✨

NEW

@abhisekp sends brownie points to @GitterBotX, @camperbot, @ltegman, @SaintPeter and @noncentz ✨ πŸ‘ ✨



Tested in GitterBotX/playground βœ…


NOTE: Added dedent module which removes unwanted indentations from template strings. Please use npm install to install the new package πŸ“¦ .

Fixes #76
Fixes dcsan/gitterbot#170

@abhisekp abhisekp referenced this pull request Apr 16, 2016

Merged

Fix/thanks #78

@SaintPeter

This comment has been minimized.

Show comment
Hide comment
@SaintPeter

SaintPeter Apr 23, 2016

Member

Any progress?

As per ☝️ This Comment in HelpContributors

There is a new user with the name E-Tank - and just entering a reply or comment on one of their questions automatically gives them brownie points.

Member

SaintPeter commented Apr 23, 2016

Any progress?

As per ☝️ This Comment in HelpContributors

There is a new user with the name E-Tank - and just entering a reply or comment on one of their questions automatically gives them brownie points.

@abhisekp

This comment has been minimized.

Show comment
Hide comment
@abhisekp

abhisekp Apr 24, 2016

Member

@SaintPeter that is addressed by @noncentz in https://github.com/FreeCodeCamp/camperbot/pull/78

Just need to remove the line linked here and then that can be merged.

Member

abhisekp commented Apr 24, 2016

@SaintPeter that is addressed by @noncentz in https://github.com/FreeCodeCamp/camperbot/pull/78

Just need to remove the line linked here and then that can be merged.

@ltegman

This comment has been minimized.

Show comment
Hide comment
@ltegman

ltegman May 1, 2016

Member

I'm really confused what is going on in this thread. @abhisekp Is this ready? I see you've written a bunch of critiques on your own PR so I'm not really sure what the status of this is.

Member

ltegman commented May 1, 2016

I'm really confused what is going on in this thread. @abhisekp Is this ready? I see you've written a bunch of critiques on your own PR so I'm not really sure what the status of this is.

@abhisekp

This comment has been minimized.

Show comment
Hide comment
@abhisekp

abhisekp May 1, 2016

Member

@ltegman it is not ready yet.. I've to implement the suggestions. Bit busy these days... Will correct them ASAP and ping you. πŸ‘

Member

abhisekp commented May 1, 2016

@ltegman it is not ready yet.. I've to implement the suggestions. Bit busy these days... Will correct them ASAP and ping you. πŸ‘

abhisekp added some commits Apr 16, 2016

Modify thanks method
- Use lodash
- Discard non-existing users and self and thank only existing ones (which also fixes thanking @/all as a bonus)
 E.g. if a user doesn't exist in gitter, then there will be no API calls to thank that user.
Improved thanks more
- fixed some messages
- formatted source a bit
@abhisekp

This comment has been minimized.

Show comment
Hide comment
@abhisekp

abhisekp May 18, 2016

Member

πŸ™… DO NOT MERGE πŸ™…

Member

abhisekp commented May 18, 2016

πŸ™… DO NOT MERGE πŸ™…

abhisekp added some commits May 18, 2016

@raisedadead raisedadead added the blocked label Jul 20, 2016

@raisedadead

This comment has been minimized.

Show comment
Hide comment
@raisedadead

raisedadead Jul 20, 2016

Member

@abhisekp I know you are busy, but this would be great to have this soon. ;)

Member

raisedadead commented Jul 20, 2016

@abhisekp I know you are busy, but this would be great to have this soon. ;)

@ltegman

This comment has been minimized.

Show comment
Hide comment
@ltegman

ltegman Oct 16, 2016

Member

Closing as stale. Please reopen when this is ready to be merged.

Member

ltegman commented Oct 16, 2016

Closing as stale. Please reopen when this is ready to be merged.

@ltegman ltegman closed this Oct 16, 2016

@ltegman ltegman removed the blocked label Oct 16, 2016

@freeCodeCamp freeCodeCamp deleted a comment from praveeno Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment