XXE in FreeColXMLReader.java

[prodigysml]

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred

The following code snippets display the usage of XMLInputFactory without securely disabling entities:

freecol/src/net/sf/freecol/common/io/FreeColXMLReader.java

Line 149 in ef284d7

XMLStreamReader xsr = xif.createXMLStreamReader(reader);

Remediation

https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat_Sheet

[mpope042]

Fixed in master on 20191227.

[carnil]

Fixing commit seems to be 8963506