Skip to content
Permalink
Browse files Browse the repository at this point in the history
FREEPBX-20436 XSS vulnerability in manager module
  • Loading branch information
Franck Danard committed Sep 3, 2019
1 parent 068a07f commit 071a509
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Manager.class.php
Expand Up @@ -67,7 +67,7 @@ public function restore($backup) {
public function doConfigPageInit($page) {
$action = isset($_REQUEST['action'])?$_REQUEST['action']:'';
//the extension we are currently displaying
$managerdisplay = isset($_REQUEST['managerdisplay'])?$_REQUEST['managerdisplay']:'';
$managerdisplay = isset($_REQUEST['managerdisplay'])?htmlentities($_REQUEST['managerdisplay'], ENT_QUOTES):'';
$name = isset($_REQUEST['name'])?$_REQUEST['name']:'';
$secret = isset($_REQUEST['secret'])?$_REQUEST['secret']:'';
$deny = isset($_REQUEST['deny'])?$_REQUEST['deny']:'0.0.0.0/0.0.0.0';
Expand Down
2 changes: 1 addition & 1 deletion views/form.php
@@ -1,7 +1,7 @@
<?php

if (isset($_REQUEST['managerdisplay'])){
$managerdisplay = $_REQUEST['managerdisplay'];
$managerdisplay = htmlentities($_REQUEST['managerdisplay'], ENT_QUOTES);
$subhead = '<h2>'._("Manager").' '.$managerdisplay.'</h2>';
$delURL = '?display=manager&amp;managerdisplay='.$managerdisplay.'&amp;action=delete';
//get details for this manager
Expand Down

0 comments on commit 071a509

Please sign in to comment.