Check BN_rand_range return value

CVE-2014-4733. In practice, the function should never fail.
FreeRADIUS · Jul 14, 2014 · 5232808 · 5232808
1 parent 4037222
commit 5232808
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c b/src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c
@@ -282,8 +282,14 @@ int compute_scalar_element (pwd_session_t *sess, BN_CTX *bnctx) {
 		goto fail;
 	}
 
-	BN_rand_range(sess->private_value, sess->order);
+	if (BN_rand_range(sess->private_value, sess->order) != 1) {
-	BN_rand_range(mask, sess->order);
+		DEBUG2("Unable to get randomness for private_value");
+		goto fail;
+	}
+	if (BN_rand_range(mask, sess->order) != 1) {
+		DEBUG2("Unable to get randomness for mask");
+		goto fail;
+	}
 	BN_add(sess->my_scalar, sess->private_value, mask);
 	BN_mod(sess->my_scalar, sess->my_scalar, sess->order, bnctx);