Skip to content
Permalink
Browse files

We should quote ${...} feature expansions

Otherwise when the feature is turned off, we start with:

	if (${feature} == 'no')

and end up with

	if ( == 'no')

Which is bad.

The old conditional parser accepted it, which is arguably wrong.
The new one is a bit smarter, and is more picky.
  • Loading branch information
alandekok committed Aug 25, 2019
1 parent 001ebd3 commit 8931eb1715678826ed5905661735b907ec74d37a
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,7 +1,7 @@
# Fixme - Base64 decode seems off for alt base64
test_pass

#if (${feature.tls} == 'no') {
#if ("${feature.tls}" == no) {
# test_pass
# return
#}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}
@@ -1,4 +1,4 @@
if (${feature.tls} == 'no') {
if ("${feature.tls}" == no) {
test_pass
return
}

0 comments on commit 8931eb1

Please sign in to comment.
You can’t perform that action at this time.