From d09e7cfbe18a21607efdeaecede2658d6b3e300a Mon Sep 17 00:00:00 2001
From: "Alan T. DeKok" <aland@freeradius.org>
Date: Mon, 24 Mar 2014 12:41:13 -0400
Subject: [PATCH] Fix radius_list_name and add regression tests for 3GPP attrs

---
 src/main/util.c         | 83 +++++++++++++++++++++++++++++++----------
 src/tests/keywords/3gpp | 19 ++++++++++
 2 files changed, 83 insertions(+), 19 deletions(-)
 create mode 100644 src/tests/keywords/3gpp

diff --git a/src/main/util.c b/src/main/util.c
index eafe542ff57c..2e5b8c2539c3 100644
--- a/src/main/util.c
+++ b/src/main/util.c
@@ -933,10 +933,10 @@ const FR_NAME_NUMBER request_refs[] = {
  * @see dict_attrbyname
  *
  * @param[in,out] name of attribute.
- * @param[in] unknown the list to return if no qualifiers were found.
+ * @param[in] default_list the list to return if no qualifiers were found.
  * @return PAIR_LIST_UNKOWN if qualifiers couldn't be resolved to a list.
  */
-pair_lists_t radius_list_name(char const **name, pair_lists_t unknown)
+pair_lists_t radius_list_name(char const **name, pair_lists_t default_list)
 {
 	char const *p = *name;
 	char const *q;
@@ -946,34 +946,79 @@ pair_lists_t radius_list_name(char const **name, pair_lists_t unknown)
 	rad_assert(name && *name);
 
 	/*
-	 *	We couldn't determine the list if:
-	 *
-	 * 	A colon delimiter was found, but the next char was a
-	 *	number, indicating a tag, not a list qualifier.
-	 *
-	 *	No colon was found and the first char was upper case
-	 *	indicating an attribute.
-	 *
+	 *	Unfortunately, ':' isn't a definitive separator for
+	 *	the list name.  We may have numeric tags, too.
 	 */
 	q = strchr(p, ':');
-	if (((q && (q[1] >= '0') && (q[1] <= '9'))) ||
-	    (!q && isupper((int) *p))) {
-		return unknown;
-	}
-
 	if (q) {
-		*name = (q + 1);	/* Consume the list and delimiter */
-		return fr_substr2int(pair_lists, p, PAIR_LIST_UNKNOWN, (q - p));
+		/*
+		 *	Check for tagged attributes.  They have
+		 *	"name:tag", where tag is a decimal number.
+		 *	Valid tags are invalid attributes, so that's
+		 *	OK.
+		 *
+		 *	Also allow "name:tag[#]" as a tag.
+		 *
+		 *	However, "request:" is allowed, too, and
+		 *	shouldn't be interpreted as a tag.
+		 *
+		 *	We do this check first rather than just
+		 *	looking up the request name, because this
+		 *	check is cheap, and looking up the request
+		 *	name is expensive.
+		 */
+		if (isdigit((int) q[1])) {
+			char const *d = q + 1;
+
+			while (isdigit((int) *d)) {
+				d++;
+			}
+
+			/*
+			 *	Return the DEFAULT list as supplied by
+			 *	the caller.  This is usually
+			 *	PAIRLIST_REQUEST.
+			 */
+			if (!*d || (*d == '[')) {
+				return default_list;
+			}
+		}
+
+		/*
+		 *	If the first part is a list name, then treat
+		 *	it as a list.  This means that we CANNOT have
+		 *	an attribute which is named "request",
+		 *	"reply", etc.  Allowing a tagged attribute
+		 *	"request:3" would just be insane.
+		 */
+		output = fr_substr2int(pair_lists, p, PAIR_LIST_UNKNOWN, (q - p));
+		if (output != PAIR_LIST_UNKNOWN) {
+			*name = (q + 1);	/* Consume the list and delimiter */
+			return output;
+		}
+
+		/*
+		 *	It's not a known list, say so.
+		 */
+		return PAIR_LIST_UNKNOWN;
 	}
 
-	q = (p + strlen(p));	/* Consume the entire string */
+	/*
+	 *	The input string may be just a list name,
+	 *	e.g. "request".  Check for that.
+	 */
+	q = (p + strlen(p));
 	output = fr_substr2int(pair_lists, p, PAIR_LIST_UNKNOWN, (q - p));
 	if (output != PAIR_LIST_UNKNOWN) {
 		*name = q;
 		return output;
 	}
 
-	return unknown;
+	/*
+	 *	It's just an attribute name.  Return the default list
+	 *	as supplied by the caller.
+	 */
+	return default_list;
 }
 
 
diff --git a/src/tests/keywords/3gpp b/src/tests/keywords/3gpp
new file mode 100644
index 000000000000..05e3fb23e740
--- /dev/null
+++ b/src/tests/keywords/3gpp
@@ -0,0 +1,19 @@
+#
+#  PRE: update
+#
+update request {
+	3GPP-IMSI := "hello"
+}
+
+#
+#  "request:[0-9]" should be parsed as a list followed
+#  by an attribute.
+#
+update control {
+	Tmp-String-0 := "%{3GPP-IMSI}"
+	Tmp-String-1 := "%{request:3GPP-IMSI}"
+}
+
+update reply {
+       Filter-Id := "filter"
+}
\ No newline at end of file