Request status check of auth+acct home servers sends Accounting-Requests to authentication port #1364

Closed
wflei opened this Issue Oct 30, 2015 · 1 comment

Projects

None yet

1 participant

@wflei
wflei commented Oct 30, 2015

If a home server is of type auth+acct and status check is configured to send requests in order to check if the server is alive, Accounting-Requests are sent to the authentication port of the home server. As according to the RFC the home server just drops accounting requests on the authentication port, a dead home server never returns to alive state.

This happens due to the check } else if (home->type == HOME_TYPE_AUTH) { in the ping_home_server function in process.c. Because the condition is not met, the } else { branch is used and an accounting request is sent, however to the port specified by the port option, which in case of an auth+acct home server is pointing to the authentication port of the home server.

Therefore the above check should be modified to include the home->type == HOME_TYPE_AUTH_ACCT case.

@alandekok alandekok closed this in a34b0bb Oct 30, 2015
@wflei
wflei commented Oct 30, 2015

That looks perfect. Thank you!

@ncopa ncopa pushed a commit to alpinelinux/aports that referenced this issue Oct 30, 2015
Leonardo Arena main/freeradius: send accounting pings to accounting port 25b1fd3
@ncopa ncopa pushed a commit to alpinelinux/aports that referenced this issue Oct 30, 2015
Leonardo Arena main/freeradius: send accounting pings to accounting port
FreeRADIUS/freeradius-server#1364
(cherry picked from commit 25b1fd3)
59a21ab
@ncopa ncopa pushed a commit to alpinelinux/aports that referenced this issue Oct 30, 2015
Leonardo Arena main/freeradius: send accounting pings to accounting port a0dba76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment