New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more verbose pool debug #1930

Open
alanbuxey opened this Issue Mar 6, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@alanbuxey
Member

alanbuxey commented Mar 6, 2017

Issue type

  • Questions about the server or its usage should be posted to the users mailing list.
  • Remote security exploits MUST be sent to security@freeradius.org.
  • Defect - Crash or memory corruption.
  • Defect - Non compliance with a standards document, or incorrect API usage.
  • Defect - Unexpected behaviour (obvious or verified by project member).
  • [x ] Feature request.

See here for debugging instructions and how to obtain backtraces.

NOTE: PATCHES GO IN PULL REQUESTS. IF YOU SUBMIT A DIFF HERE, THE DEVELOPMENT TEAM WILL HUNT YOU DOWN AND BEAT YOU OVER THE HEAD WITH YOUR OWN KEYBOARD.

Defect/Feature description

How to reproduce issue

current pool/connection output is mixed. sometimes there is the module name involved, sometimes not eg

Mon Mar  6 23:03:39 2017 : Info  : (127810,127789)                    Need 1 more connections to reach min connections (64)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)        mschap - Need 1 more connections to reach min connections (64)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)                  Deleting connection (1287)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)                  Need 64 more connections to reach min connections (64)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Deleting connection (1309)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Need 64 more connections to reach min connections (64)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Deleting connection (1313)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Need 64 more connections to reach min connections (64)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Deleting connection (1322)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Need 64 more connections to reach min connections (64)
Mon Mar  6 23:03:39 2017 : Info  : (127826,127819)            Deleting connection (1288)

would be good if all pool-using modules printed their IDs in those outputs - so admins can easily see which module is unable to make its connections.. oh, and "Need 1 more connections" is annoying to see - "Need 1 more connection" :)

@alandekok

This comment has been minimized.

Show comment
Hide comment
@alandekok

alandekok Mar 7, 2017

Member

In v3 and v4 it has a log_prefix (see src/main/connection.c). It is usually set to rlm_foo, i.e. the instance name.

The issue here is that log_prefix isn't being used in the INFO log messages.

As always, patches are welcome...

Member

alandekok commented Mar 7, 2017

In v3 and v4 it has a log_prefix (see src/main/connection.c). It is usually set to rlm_foo, i.e. the instance name.

The issue here is that log_prefix isn't being used in the INFO log messages.

As always, patches are welcome...

@alandekok alandekok closed this in db52e47 Mar 7, 2017

arr2036 added a commit that referenced this issue Mar 7, 2017

@arr2036 arr2036 reopened this Mar 7, 2017

@arr2036

This comment has been minimized.

Show comment
Hide comment
@arr2036

arr2036 Mar 7, 2017

Member

I'll look at this tomorrow. There's macros that mean you don't double prefix log messages with the module name, but for some reason they're not working for the REQUEST == NULL invocations.

Member

arr2036 commented Mar 7, 2017

I'll look at this tomorrow. There's macros that mean you don't double prefix log messages with the module name, but for some reason they're not working for the REQUEST == NULL invocations.

@alanbuxey

This comment has been minimized.

Show comment
Hide comment
@alanbuxey

alanbuxey Apr 13, 2017

Member

any update on this one Arran?

Member

alanbuxey commented Apr 13, 2017

any update on this one Arran?

@alandekok alandekok added the v4.0.x label Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment