New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configcheck not executed before stop/restart (systemd) #2080

Open
sts opened this Issue Sep 27, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@sts

sts commented Sep 27, 2017

The freeradius.service file which is supplied with the Freeradius Debian package restarts Freeradius regardless whether the configuration test succeeds. This behaviour changed when switching to systemd as the old sysvinit script returned, before the running daemon was killed in case the current configuration didn't succeed the configcheck.

The systemd service file facilitates the ExecStartPre option, to run a config check, but ExecStartPre is only executed before service start, which is IMO the init action where such a check is least useful.

Other things, like the our freeradius Puppet module, assumes the old sysvinit behaviour to avoid service outages in case a broken configuration gets deployed.
https://github.com/djjudas21/puppet-freeradius/blob/master/manifests/init.pp#L255

Now, the bad news is that systemd obviously doesn't provide a way to run a config check before stop and restart. One could maybe use the workaround used with ExecReloadPre and we could switch the Puppet module to do a reload instead:
systemd/systemd#2175

@alandekok alandekok added the v3.0.x label Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment