Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One letter expansions seem to break other expansions in the users file #2216

Open
arr2036 opened this Issue Apr 23, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@arr2036
Copy link
Member

arr2036 commented Apr 23, 2018

Issue type

  • Questions about the server or its usage should be posted to the users mailing list.
  • Remote security exploits MUST be sent to security@freeradius.org.
  • Defect - Crash or memory corruption.
  • Defect - Non compliance with a standards document, or incorrect API usage.
  • [x ] Defect - Unexpected behaviour (obvious or verified by project member).
  • Feature request.

See here for debugging instructions and how to obtain backtraces.

Defect/Feature description

How to reproduce issue

Use the "%T" expansion in the reply list in an entry in the users file. Not only will it not expand, but it'll break all other expansions on that lite.

@alandekok

This comment has been minimized.

Copy link
Member

alandekok commented Apr 23, 2018

https://github.com/FreeRADIUS/freeradius-server/blob/v4.0.x/src/lib/util/pair.c#L2770

If you do %{User-Name} %T it works. Doing %T %{User-Name} fails.

@arr2036

This comment has been minimized.

Copy link
Member Author

arr2036 commented Apr 24, 2018

Ah, we can do much better than that now i.e. feed the string to xlat parser and see what it says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.