New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should use UPSERT for accounting to Postgresql #2244

Open
alandekok opened this Issue Jun 7, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@alandekok
Member

alandekok commented Jun 7, 2018

We currently have the config do manual UPDATE, and if that fails, do INSERT.

PostgreSQL 9.3 and later supports UPSERT: https://www.postgresql.org/docs/current/static/sql-insert.html

The default configuration should be updated to use this.

For v3, the UPSERT should be commented out by default.

For v4, the UPSERT should be the default configuration. And the old-style INSERT / UPDATE should be commented out by default.

UPSERT can likely increase performance in high load situations.

@arr2036

This comment has been minimized.

Member

arr2036 commented Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment