Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
sqlippool Pool-Name not defined #2282
I have a use case for the sqlippool module where we defined our own Pool-Name attribute (specific dictinary) with the following meaning:
For one of our group in radgroupcheck we only have DHCPv4-Pool-Name & DHCPv6-Pool-Name-Pd attributes set but NOT Pool-Name. When the module is running it is not possible to allocate any IP address as the Pool-Name attribute is 'hard coded'.
My suggestion would be to have this specific check based on the inst->pool_name variable instead of a hardcoded pool-name. By doig this way we would be able to defined our own Pool-Name attribute inside the module configuration.
I can work on this modification and send a pull request if you want.
After checking v3 code and doing some testing, it is indeed possible to define a custom pool_name in the sqlippool configuration but the function which handled checking for attribute is using the 'Pool-Name' hardcoded and not the one from the configuration. I will send 2 pull request for both version.
From my understaing the pool_name configuration variable is used to set a default pool_name in case the pool is not found in the check attribute (default value for pool_name: ippool).
@alandekok : Do you confirm that ?
I would rather create a new configuration variable named pool_attribute which will be used to specifiy a custom pool attribute with default value beind 'Pool-Name'. This new configuration would be present along with the existing pool_name.