New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radius not correctly rotating linelog after first rotate #2320

Open
ivlovric opened this Issue Oct 2, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@ivlovric

ivlovric commented Oct 2, 2018

Tried with radius 3.0.13 and 3.0.17 where logrotate will rotate one time and after that original logfile would be empty and rotated file would be filling up which is not correct behavior.
Rotating works with logrotate option "copytruncate" which is not option for us because we are logging accounting events and dont want to loose any accounting records that this option might trigger.

Also correct rotating is present when triggering restart of radius service in postrotate directive instead of reload. Restarting of service is also not correct option to use here.

We are using Centos 7.5.1804

This is our logrotate script:

/var/log/radius/linelog-accounting {
        maxsize 1000k
        nocompress
        nocopytruncate
        notifempty
        rotate 999
        create 644 radiusd radiusd
        postrotate
       #radmin  -e hup
                kill -HUP `cat /var/run/radiusd/radiusd.pid`
       #systemctl reload radiusd
       #/usr/bin/systemctl restart radiusd
        endscript
}

Please advise and if this is bug, please analyze, will gladly give more input or debugging data.

@mcnewton

This comment has been minimized.

Show comment
Hide comment
@mcnewton

mcnewton Oct 2, 2018

Member

Try v3.0.x HEAD. A fix went in which may solve this.

Member

mcnewton commented Oct 2, 2018

Try v3.0.x HEAD. A fix went in which may solve this.

@ivlovric

This comment has been minimized.

Show comment
Hide comment
@ivlovric

ivlovric Oct 2, 2018

Thank you for your reply. As said, we were already using versions 3.0.13 and 3.0.17 but without success. Is there anything else we might be missing here?

ivlovric commented Oct 2, 2018

Thank you for your reply. As said, we were already using versions 3.0.13 and 3.0.17 but without success. Is there anything else we might be missing here?

@alandekok

This comment has been minimized.

Show comment
Hide comment
@alandekok

alandekok Oct 2, 2018

Member

What you're missing is that changes have gone into github since 3.0.17 was released. Please try the v3.0.x branch from github, as Matthew recommended above.

Member

alandekok commented Oct 2, 2018

What you're missing is that changes have gone into github since 3.0.17 was released. Please try the v3.0.x branch from github, as Matthew recommended above.

@ivlovric

This comment has been minimized.

Show comment
Hide comment
@ivlovric

ivlovric Oct 9, 2018

After fighting to compile latest build where libkqueue dependency was an obstacle we have successfully built latest master v3.0.x branch that solves log rotating issue. This issue can be closed now. Thanks!

ivlovric commented Oct 9, 2018

After fighting to compile latest build where libkqueue dependency was an obstacle we have successfully built latest master v3.0.x branch that solves log rotating issue. This issue can be closed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment