New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql queries.conf literal Chap-Password #2357

Open
hanetzer opened this Issue Nov 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@hanetzer

hanetzer commented Nov 19, 2018

Default queries.conf for postgresql seems to be a bit off.

post-auth {
	# Write SQL queries to a logfile. This is potentially useful for bulk inserts
	# when used with the rlm_sql_null driver.
#	logfile = ${logdir}/post-auth.sql

	query = "\
		INSERT INTO ${..postauth_table} \
			(username, pass, reply, authdate) \
		VALUES(\
			'%{User-Name}', \
			'%{%{User-Password}:-Chap-Password}', \
			'%{reply:Packet-Type}', \
			NOW())"
}

Should not '%{%{User-Password}:-Chap-Password}' be '%{%{User-Password}:-%{Chap-Password}}' as it is for the sqlite, mysql, and oracle?

@arr2036

This comment has been minimized.

Member

arr2036 commented Nov 19, 2018

Yes, most likely. Can you send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment