Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file change reload not working as expected #2846

Open
richardschuetz opened this issue Aug 5, 2019 · 2 comments

Comments

@richardschuetz
Copy link

commented Aug 5, 2019

Issue type

  • Defect - Unexpected behaviour (obvious or verified by project member).

Defect

If I edit the users file and trigger multiple configuration reloads with SIGHUP afterwards, the files module gets reloaded every time, although configuration has only been changed once.

Additionally changes in files included in users with $INCLUDE are not detected at all.

How to reproduce the issue

  1. Edit users file
  2. Trigger configuration reload
  3. Trigger another configuration reload

The files module gets reloaded both times.

Output of [radiusd|freeradius] -X showing issue occurring

Ready to process requests
Received HUP signal
  # Trying to reload module "files"
  files {
        filename = "/etc/freeradius/3.0/mods-config/files/authorize"
        acctusersfile = "/etc/freeradius/3.0/mods-config/files/accounting"
        preproxy_usersfile = "/etc/freeradius/3.0/mods-config/files/pre-proxy"
  }
reading pairlist file /etc/freeradius/3.0/mods-config/files/authorize
reading pairlist file /etc/freeradius/3.0/mods-config/files/accounting
reading pairlist file /etc/freeradius/3.0/mods-config/files/pre-proxy
 Module: Reloaded module "files"
HUP - Files loaded by a module have changed.
Ready to process requests
Ready to process requests
Received HUP signal
  # Trying to reload module "files"
  files {
        filename = "/etc/freeradius/3.0/mods-config/files/authorize"
        acctusersfile = "/etc/freeradius/3.0/mods-config/files/accounting"
        preproxy_usersfile = "/etc/freeradius/3.0/mods-config/files/pre-proxy"
  }
reading pairlist file /etc/freeradius/3.0/mods-config/files/authorize
reading pairlist file /etc/freeradius/3.0/mods-config/files/accounting
reading pairlist file /etc/freeradius/3.0/mods-config/files/pre-proxy
 Module: Reloaded module "files"
HUP - Files loaded by a module have changed.
Ready to process requests
@alandekok

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Which version? What OS? When I try it here, it works for the "users" file.

It ignores files loaded via $INCLUDE. That is unfortunately a limitation, and won't be fixed in the v3 release. Doing so will require substantial changes, which are impossible at this time.

@richardschuetz

This comment has been minimized.

Copy link
Author

commented Aug 5, 2019

Which version? What OS? When I try it here, it works for the "users" file.

I am able to reproduce the behavior with both FreeRADIUS 3.0.16 on Ubuntu 18.04.2 LTS and FreeRADIUS 3.0.19 on Arch Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.