Freeradius 2.2.6: Children hung in heavy load scenario + FIX #880

Closed
Kishi0815 opened this Issue Jan 20, 2015 · 1 comment

Projects

None yet

3 participants

@Kishi0815

Freeradius 2.2.6 gives the following error in a heavy load scenario:

         WARNING: Child is hung for request * in component <core> module .

Applying the patches to event.c done in Nov 2014 did not solve the problem. The following patch however solves the problem and no more error messages are displayed:

--- src/main/event.c    2015-01-20 12:38:30.000000000 +0100
+++ src/main/event.c    2015-01-20 12:38:53.000000000 +0100
@@ -508,7 +508,7 @@
         *      up) OR there's still a child thread handling it, THEN
         *      delay some more.
         */
-       if ((request->child_state = REQUEST_QUEUED) ||
+       if ((request->child_state == REQUEST_QUEUED) ||
            (request->thread_id != NO_CHILD_THREAD)) {
                /*
                 *      Cap delay at max_request_time
@arr2036
Member
arr2036 commented Jan 20, 2015

and this is why compiler warnings are important :) - i'll leave Alan to do the commit o' shame on this one. Good catch.

@alandekok alandekok added a commit that referenced this issue Jan 20, 2015
@alandekok alandekok Fix typo. Closes #880 8ae95a7
@alandekok alandekok closed this Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment