Correctly copy vendor specific attributes in copy_request_to_tunnel #1544

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mcnewton
Member

Checking just vp->da->attr is not enough; we also need to ensure that a vendor is not set. Specifically Cisco-AVPair is attribute 1, the same as User-Name...

@mcnewton mcnewton Correctly copy vendor specific attributes in copy_request_to_tunnel
Checking just vp->da->attr is not enough; we also need to ensure
that a vendor is not set. Specifically Cisco-AVPair is attribute 1,
the same as User-Name...
bd04c8c
@alandekok
Member

I put the vendor check above the switch, which meets more of the existing code style.

@alandekok alandekok closed this Feb 24, 2016
@mcnewton
Member

Great thanks. I find that harder to read, but I guess it saves a few cycles :).

@mcnewton mcnewton deleted the mcnewton:crtt30 branch Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment