/freeradius-server

Correctly copy vendor specific attributes in copy_request_to_tunnel #1544

Closed
wants to merge 1 commit into
from
+4 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mcnewton @alandekok
@mcnewton
Member

mcnewton commented Feb 22, 2016

Checking just vp->da->attr is not enough; we also need to ensure that a vendor is not set. Specifically Cisco-AVPair is attribute 1, the same as User-Name...
@mcnewton mcnewton Correctly copy vendor specific attributes in copy_request_to_tunnel 
Checking just vp->da->attr is not enough; we also need to ensure
that a vendor is not set. Specifically Cisco-AVPair is attribute 1,
the same as User-Name...
bd04c8c

@alandekok alandekok added a commit that referenced this pull request Feb 24, 2016

@alandekok alandekok Only normal attributes are treated specially. Fixes #1544 fceb137
@alandekok
Owner

alandekok commented Feb 24, 2016

I put the vendor check above the switch, which meets more of the existing code style.

alandekok closed this Feb 24, 2016

@mcnewton
Member

mcnewton commented Feb 24, 2016

Great thanks. I find that harder to read, but I guess it saves a few cycles :).

mcnewton deleted the mcnewton:crtt30 branch Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment