/freeradius-server

*vps being set to NULL is valid #1778

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jrouzierinverse @alandekok
@jrouzierinverse
Contributor

jrouzierinverse commented Oct 11, 2016

Receiving lots of
'SOFT ASSERT FAILED src/modules/rlm_perl/rlm_perl.c[703]: *vps' in the radius log.

However get_hv_content and do_perl set the value pair to NULL before pairadd_sv is called.

https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_perl/rlm_perl.c#L741

https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_perl/rlm_perl.c#L870

@alandekok alandekok added a commit that referenced this pull request Oct 11, 2016

@alandekok alandekok vps may be NULL. Fixes #1778 
The VERIFY_LIST macro shouild be protected by an "if *vps" check.
It should also be run once all of the VPs have been added,
and not on every VP which is added.
This commit was signed with a verified signature.
@alandekok alandekok Alan DeKok
GPG key ID: 7D0E79CD77621ECD Learn about signing commits
cbb0881
@alandekok
Owner

alandekok commented Oct 11, 2016

I've pushed an alternate fix.

alandekok closed this Oct 11, 2016

@alandekok alandekok added a commit that referenced this pull request Oct 11, 2016

@alandekok alandekok vps may be NULL. Fixes #1778 
The VERIFY_LIST macro shouild be protected by an "if *vps" check.
It should also be run once all of the VPs have been added,
and not on every VP which is added.

Manual merge of cbb0881
This commit was signed with a verified signature.
@alandekok alandekok Alan DeKok
GPG key ID: 7D0E79CD77621ECD Learn about signing commits
80fdd62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment