Removed RAD_CONFIG entry in Perl

[qnet-herwin]

This is an undocumented read-only copy of RAD_CHECK. If you ever need
something like this, it can be created very easily in Perl.

This should not be merged to 3.0.x, as it breaks backwards
compatibility.

[arr2036]

Wrong one. RAD_CHECK is deprecated, RAD_CONFIG is correct. The code should all be switched to RAD_CONFIG.

[arr2036]

The idea is the list names in the modules match the list name in the server core...

[qnet-herwin]

In that case I assume https://github.com/FreeRADIUS/freeradius-server/blob/master/src/modules/rlm_perl/rlm_perl.c#L876 should be updated as well, to make the RAD_CONFIG hash read/write instead of read-only?

[arr2036]

Yes

[qnet-herwin]

Just pushed an update

[arr2036]

Looks good. Thanks.

If you have any ideas about avoiding all the unnecessary marshalling and unmarshaling? Seems really inefficient the way we're doing it now...

[qnet-herwin]

On 27-06-14 14:41, Arran Cudbard-Bell wrote:

If you have any ideas about avoiding all the unnecessary marshalling and
unmarshaling? Seems really inefficient the way we're doing it now...

The default trick for things like this is to create a hashref (reference
to a hash) instead of a hash. This way you only have to pass a reference
(a bit like a pointer in C) to the perl script.

I thought there was some information on this in the O'Reily books
"Programming Perl" and "Advanced Perl Programming", but there wasn't.
Some possible interesting reads:

• http://www.devx.com/assets/devx/3724.pdf
• http://perldoc.perl.org/perlembed.html

If you're looking for an example implementation, try mod_perl of Apache.
That's probably the most mature perl embedding there is.

Herwin Weststrate