Prevent assert(0) in rlm_rest #808

Merged
merged 1 commit into from Oct 7, 2014

Projects

None yet

3 participants

@qnet-herwin
Contributor

If the RADIUS server is compiled without JSON support, it is still possible that the other end of the rlm_rest module returns JSON. This triggered an "assert(0)" and crashed the server. This fixes this by printing an error message to indicate that the reply of the REST server couldn't be parsed, and failing the module gracefully.

@qnet-herwin qnet-herwin Prevent assert(0) in rlm_rest
If the RADIUS server is compiled without JSON support, it is still possible that the other end of the rlm_rest module returns JSON. This triggered an "assert(0)" and crashed the server. This fixes this by printing an error message to indicate that the reply of the REST server couldn't be parsed, and failing the module gracefully.
f15bee5
@alandekok alandekok merged commit ced2350 into FreeRADIUS:master Oct 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@arr2036 arr2036 added a commit that referenced this pull request Oct 7, 2014
@arr2036 arr2036 Correct fix for #808 33716e3
@arr2036 arr2036 added a commit that referenced this pull request Oct 7, 2014
@arr2036 arr2036 Correct fix for #808 94458d0
@arr2036
Member
arr2036 commented Oct 7, 2014

To trigger this you would need to send POST data and the server return a Content-Type of JSON.

@qnet-herwin qnet-herwin deleted the unknown repository branch Oct 8, 2014
@pwdng pwdng added a commit to pwdng/freeradius-server that referenced this pull request Oct 24, 2014
@arr2036 @pwdng arr2036 + pwdng Correct fix for #808 3dc5699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment