Permalink
3 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fixed oob read in ntlm_read_ntlm_v2_response
- Loading branch information
1 parent
f59ad0f
commit c098f21
Showing
1 changed file
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c098f21There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akallabeth In
ntlm_read_ntlm_v2_client_challenge(), whyif (Stream_GetRemainingLength(s) < 28)? The code looks like it actually reads 112 bytes from the stream. Am I missing something?c098f21There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcullum-rh No, the check is correct.
28bytes are read in and the remaining length copied toNTLM_AV_PAIRc098f21There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akallabeth ah I misunderstood the calls as "8 UINTs" instead of "1 byte". Thanks for clarifying, your response, and all the hard work!