Wrong error code when NLA auth fails

[giox069]

From remmina issue https://github.com/FreeRDP/Remmina/issues/507

Trying to connect to a Windows 7 machine, using xfreerdp + NLA:

xfreerdp /sec:nla /v:mypc.remotedom.dom:21017 /u:jsmith /d:domain

When I type a WRONG password, freerdp sets the wrong error code to FREERDP_ERROR_CONNECT_TRANSPORT_FAILED [0x2000D]

[20:17:03:515] [30711:1583720192] [ERROR][com.freerdp.core] - freerdp_set_last_error 0x2000D
[20:17:03:516] [30711:1583720192] [ERROR][com.freerdp.client.x11] - Authentication only, exit status 1

The last working xfreerdp is commit eddfee5 of Feb 15, which correctly calls freerdp_set_last_error(FREERDP_ERROR_AUTHENTICATION_FAILED) [0x20009].
Here is the output when I type a wrong NLA password in the older freerdp.

[20:02:41:159] [29131:-501631232] [ERROR][com.freerdp.core.nla] - nla_recv() error: -1
[20:02:41:159] [29131:-501631232] [ERROR][com.freerdp.core] - freerdp_set_last_error 0x20009
[20:02:41:159] [29131:-501631232] [ERROR][com.freerdp.core.transport] - Authentication failure, check credentials.If credentials are valid, the NTLMSSP implementation may be to blame.
[20:02:41:159] [29131:-501631232] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure
[20:02:41:160] [29131:-501631232] [ERROR][com.freerdp.client.x11] - Authentication only, exit status 1

[lemonmojo]

+1
connectErrorCode is always set to CONNECTERROR.

[lemonmojo]

Also, when using a Remote Desktop Gateway, there's currently no way of knowing whether the gateway or destination host credentials have been rejected (apart from looking at the log which isn't feasible in GUI-only applications).

[giox069]

@lemonmojo: I'm closing this issue thanks to PR #2824 merged. For Remote Desktop Gateway, test it and reopen a new one if the problem is still here.