Freezes the screen xfreerdp in LinuxMint when switching from full screen mode (Ctrl+Alt+Enter)

[ava57r]

Use - version This is FreeRDP version 2.0.0~dev (git n/a)
OS - Linux Mint 18.1 Serena
Desktop - Cinnamon 3.2.7

Connect to Windows server 2008 RDP gateway with option /f
When switching from full screen mode pressing (Ctrl+Alt+Enter) 3 times

1. Full screen mode -> window mode
2. Window mode -> Full screen mode
3. Full screen mode - window mode
   FreeRDP freezes
   Lost icons and panels, window freerdp becomes transparent

syslog - empty
run terminal (Ctrl+Alt+F1) and kill proccess

[akamuza]

Ubuntu 16.04, Intel graphics G33 , FreeRDP version 2.0.0-dev (latest nightly build).
Same problem.
After switching several times to/from fullscreen - screen just freezes and nothing helps but reboot.
Using +toggle-fullscreen doesn't help.

[wolfstefan]

I figured out that this issue was introduced with the commits 48be081 and 7ddd15d. To be more precise, calling XMoveWindow before xf_SendClientEvent seems to break it.

The attached patch removes all calls of XMoveWindow in this case and fixes the problem as far as I have tested it. Moreover, it prevents the window from getting lower after each switch between fullscreen and non-fullscreen. However, I think that there is a reason for the XMoveWindow calls and therefore this patch might break something else. It would be nice if one of the developers could take a look at it.

P.S.: thanks to all developers for the amazing work on FreeRDP :)

fullscreen.diff.txt

[akamuza]

In my case XMoveWindow is a good idea, because when I exit fullscreen for the very first time then the top bar of my rdp window is hidden by Ubuntu's top toolbar, and thus I can not see my close,minimize buttons of the rdp window.
And because of that I have to enter/exit fullscreen once more in order to move rdp window a bit lower.

Of cause that's not a big deal, jast an additional information on XMoveWindow

[wolfstefan]

That's a good point. In this case it should be enough to call XMoveWindow after xf_SendClientEvent when leaving fullscreen. Doing this would give back the behavior that the window gets lower each time switching and it shouldn't break switching more than once on Mint.

[wolfstefan]

This issue still occurs on the current master and up-to-date Linux Mint 18.2. I don't know enough about X11 to say whether that should work and might be rather a bug in Cinnamon. Therefore, it would be nice if one of the developers who is more aware of X11 could comment on this issue.

[akallabeth]

Could not reproduce with current nightlies, could you give some more details?

[akallabeth]

It would also be helpful to get a broken run with /log-level:trace output attached.

[wolfstefan]

Have you tried it with Linux Mint and Cinnamon as desktop? Linux Mint with Cinnamon is the only system on which the problem occurred. I couldn't reproduce the issue on the other systems I tested (Fedora with Gnome and Ubuntu with Unity).

I attached the output but I cut the NLA part since I don't know if it includes any credentials.
rdp_log.txt

[akallabeth]

@wolfstefan Tried with cinnamon on debian (don't have mint ready to use), no such issues at all. Also nothing suspicious in the log...

[wolfstefan]

Can you please tell me which Cinnamon version (cinnamon --version in terminal) you use? I will then test it with your version on Linux Mint.

[akallabeth]

3.2.7-4 is the cinnamon debian package (stretch/stable)

[wolfstefan]

@akallabeth Are you sure that you switched between fullscreen and non-fullscreen at least twice? Switching only once doesn't trigger the issue. I'm asking since I can also reproduce the issue with a newly installed Debian 9 with Cinnamon.

I found out that the issue was introduced on Cinnamon side between version 2.4 and 2.6 with the following commit: linuxmint/muffin@c055801 . That commit changes the window manager's default placement mode (dconf value org.cinnamon.muffin.placement-mode) from automatic to center. So everyone who is affected by the issue can set that value back to automatic as a workaround.

[akallabeth]

@wolfstefan Did test that with at least 5x but will check the settings. (Maybe some older settings were still around in my user home)

[ava57r]

$ uname -a
Linux pc.localdomain 4.13.16-202.fc26.x86_64 #1 SMP Thu Nov 30 15:39:32 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

$ lsb_release -a
LSB Version:	:core-4.1-amd64:core-4.1-noarch
Distributor ID:	Fedora
Description:	Fedora release 26 (Twenty Six)
Release:	26
Codename:	TwentySix

$ cinnamon --version
Cinnamon 3.6.6

This problem is reproduced
OS installed in may 2017

In the mode of trace window shows that the xfreerdp to become transparent and logging of actions continues in the terminal
rdp_trace_11122017.txt

[akallabeth]

Ok, finally got it to reproduce.
Special settings necessary:

• Use default settings of cinnamon (create new user)
• Single monitor setup (could not reproduce with secondary monitor attached)

[akallabeth]

Looks like no easy solution is available (thank you, nice little fullscreen mess with X11 window managers) without breaking something else.
Will delay this for the time being.