Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to build with LibreSSL 2.9.0 #5170

Closed
metalefty opened this issue Dec 25, 2018 · 3 comments
Closed

fails to build with LibreSSL 2.9.0 #5170

metalefty opened this issue Dec 25, 2018 · 3 comments

Comments

@metalefty
Copy link
Contributor

Describe the bug
Fails to build with LibreSSL 2.9.0. Found while testing #5049 on FreeBSD. It builds fine with LibreSSL 2.8.3 but fails with 2.9.0 due to structual change.

FAILED: libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o
/usr/bin/cc -DCMAKE_BUILD_TYPE=Release -DEXT_PATH=\"/usr/local/lib/freerdp2/extensions\" -DFREERDP_EXPORTS -DHAVE_CONFIG_H -DWINPR_EXPORTS -DWITH_OPENSSL -DWITH_WAYLAND -DWITH_X11 -DWITH_XKBFILE -D_FILE_OFFSET_BITS=64 -Dfreerdp_EXPORTS -I.
-Iinclude -I/wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/include -I/wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/winpr/include -Iwinpr/include -I/usr/local/include -O2 -pipe  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno-c11-extensions -Wno-gnu -Wno-unused-command-line-argument -Wno-deprecated-declarations -DWINPR_DLL -O2 -pipe  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -fPIC -MD -MT libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o -MF libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o.d -o libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o   -c /wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/libfreerdp/crypto/tls.c
/wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/libfreerdp/crypto/tls.c:1048:17: error: no member named 'alert_dispatch' in 'struct ssl3_state_st'
                tls->ssl->s3->alert_dispatch = 1;
                ~~~~~~~~~~~~  ^
/wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/libfreerdp/crypto/tls.c:1049:17: error: no member named 'send_alert' in 'struct ssl3_state_st'
                tls->ssl->s3->send_alert[0] = tls->alertLevel;
                ~~~~~~~~~~~~  ^
/wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/libfreerdp/crypto/tls.c:1050:17: error: no member named 'send_alert' in 'struct ssl3_state_st'
                tls->ssl->s3->send_alert[1] = tls->alertDescription;
                ~~~~~~~~~~~~  ^
/wrkdirs/usr/ports/net/freerdp/work/FreeRDP-2.0.0-rc4/libfreerdp/crypto/tls.c:1052:21: error: no member named 'wbuf' in
'struct ssl3_state_st'
                if (tls->ssl->s3->wbuf.left == 0)
                    ~~~~~~~~~~~~  ^
4 errors generated.
ninja: build stopped: subcommand failed.
@akallabeth
Copy link
Member

@metalefty did they implement the openssl 1.1 API? Then a new define check may be necessary.

@akallabeth akallabeth added this to the 2.0.0 milestone Jan 7, 2019
akallabeth added a commit to akallabeth/FreeRDP that referenced this issue Jan 7, 2019
@metalefty
Copy link
Contributor Author

LGTM. Testing.

@metalefty
Copy link
Contributor Author

Confirmed it builds with LibreSSL 2.9.0.

@mfleisz mfleisz closed this as completed in 0c83efa Jan 8, 2019
mfleisz added a commit that referenced this issue Jan 8, 2019
Fix #5170: Disable custom TLS alert for libressl > 2.8.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants