Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xf_keyboard.c #1705

Closed
wants to merge 1 commit into from
Closed

Update xf_keyboard.c #1705

wants to merge 1 commit into from

Conversation

grpomega
Copy link
Contributor

The power button is trapped by the xfreerdp when in fullscreen mode. I would like xfreerdp to exit immediately and give the calling program some idea of what happened. Exit code of 124 is given. This is the x keycode for the power button. "Power Button" is sent to stderr. Either one of these can be inspected by a calling program and the information used for proper control.

The power button is trapped by the xfreerdp when in fullscreen mode.  I would like xfreerdp to exit immediately and give the calling program some idea of what happened.  Exit code of 124 is given.  This is the x keycode for the power button.  "Power Button" is sent to stderr.  Either one of these can be inspected by a calling program and the information used for proper control.
@bmiklautz
Copy link
Member

@freerdp-bot test.

@bmiklautz
Copy link
Member

@grpomega I do have two considerations regarding this pull request:

  • power button might be handled by the system (it's not necessarily trapped by xfreerdp)
  • you shouldn't just call exit but disconnect the client properly instead.

@freerdp-bot
Copy link

Can one of the members verify this patch?

1 similar comment
@freerdp-bot
Copy link

Can one of the members verify this patch?

@bmiklautz
Copy link
Member

@freerdp-bot test.

@freerdp-bot
Copy link

Test PASSed.
Refer to this link for build results: https://ci.freerdp.com/job/PullRequestBuilder/135/

@grpomega
Copy link
Contributor Author

Agreed, the system grabs the power button event when not in full screen mode; but when in full screen mode xfreerdp traps and ignores the x scancode of 0x7c. I agree that an abrupt termination buried deeply in this code is unsightly. Is there a termination function one can call which leads to a more graceful termination with supplied exit code?

@freerdp-bot
Copy link

Can one of the admins verify this patch?

@realjiangms
Copy link
Contributor

@grpomega
Maybe following way could be accepted
xfc->disconnect = TRUE;

@bmiklautz
Copy link
Member

Closing this pull request.

  • pull request wasn't update for a while

@bmiklautz bmiklautz closed this Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants