New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xf_keyboard.c #1705
Update xf_keyboard.c #1705
Conversation
The power button is trapped by the xfreerdp when in fullscreen mode. I would like xfreerdp to exit immediately and give the calling program some idea of what happened. Exit code of 124 is given. This is the x keycode for the power button. "Power Button" is sent to stderr. Either one of these can be inspected by a calling program and the information used for proper control.
@freerdp-bot test. |
@grpomega I do have two considerations regarding this pull request:
|
Can one of the members verify this patch? |
1 similar comment
Can one of the members verify this patch? |
@freerdp-bot test. |
Test PASSed. |
Agreed, the system grabs the power button event when not in full screen mode; but when in full screen mode xfreerdp traps and ignores the x scancode of 0x7c. I agree that an abrupt termination buried deeply in this code is unsightly. Is there a termination function one can call which leads to a more graceful termination with supplied exit code? |
Can one of the admins verify this patch? |
@grpomega |
Closing this pull request.
|
The power button is trapped by the xfreerdp when in fullscreen mode. I would like xfreerdp to exit immediately and give the calling program some idea of what happened. Exit code of 124 is given. This is the x keycode for the power button. "Power Button" is sent to stderr. Either one of these can be inspected by a calling program and the information used for proper control.