FindGStreamer_1_0: fix build failure for new gstreamer versions #2910
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot add @dupondje to whitelist |
| PATH_SUFFIXES gstreamer-1.0 | ||
| ) | ||
| string(REGEX MATCH "(.*)>=(.*)" _dummy "${_pkgconfig_name}") | ||
| if ("${CMAKE_MATCH_2}" STREQUAL "") |
There was a problem hiding this comment.
As we never pass a extra version comparison here this check regex isn't required for us. But it also doesn't hurt.
|
If all gstreamer pkg-config files exists this works like a charm. |
|
Bump. Tested on Arch Linux with gstreamer 1.6.0 and commit d277346. Any progress on this PR? |
|
@yan12125 generally no objection but I'm still waiting on the answer on the second comment. |
|
Thanks for the information. Hope it merged soon :) |
|
We should sort out the GStreamer_FIND_VERSION at some point but as the version is checked specially afterwards it's ok for now. |
FindGStreamer_1_0: fix build failure for new gstreamer versions
On newer GStreamer versions FreeRDP fails to build with the following error.
/usr/include/gstreamer-1.0/gst/gstelement.h:55:27: fatal error: gst/gstconfig.h: Bestand of map bestaat niet
The patch was taken from:
WebKit/WebKit@c5a29d1#diff-277559c7222bb7abe4c5ef38647cce71
I tested this on Ubuntu 15.10 and solves my build error.