New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry: a skeleton for the MS-RDPEGT channel #4301

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
4 participants
@hardening
Contributor

hardening commented Dec 6, 2017

The base for implementing the MS-RDPEGT client channel that allows to track window geometry.

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 6, 2017

Build finished.

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/2465/

@hardening hardening force-pushed the hardening:geometry branch from b67d860 to 1fbefa7 Dec 6, 2017

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 6, 2017

Build finished.

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/2466/

@hardening hardening force-pushed the hardening:geometry branch from 1fbefa7 to 6523b44 Dec 6, 2017

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 6, 2017

Build finished.

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/2467/

@akallabeth

LGTM

@mfleisz

Apart from the broken len check LGTM

rgndata->boundingRect.height = bottom - rgndata->boundingRect.y;
len -= 32;
if (len / 4 < rgndata->nRectCount)

This comment has been minimized.

@mfleisz

mfleisz Dec 7, 2017

Member

I think this should be len / 16 (4 * sizeof(UINT32))

This comment has been minimized.

@hardening

hardening Dec 8, 2017

Contributor

good catch

RDH_RECTANGLE = 1
};
struct _FREERDP_RGNDATA {

This comment has been minimized.

@mfleisz

mfleisz Dec 7, 2017

Member

{ Formatting (same for the enums above)

geometry: a skeleton for the MS-RDPEGT channel
The base for implementing the MS-RDPEGT client channel that allows to track window
geometry.

@hardening hardening force-pushed the hardening:geometry branch from 6523b44 to a6cfd3c Dec 8, 2017

@hardening

This comment has been minimized.

Contributor

hardening commented Dec 8, 2017

@mfleisz 's remarks have been addressed

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 8, 2017

Build finished.

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/2471/

@hardening

This comment has been minimized.

Contributor

hardening commented Dec 12, 2017

@mfleisz are the changes ok for you ?

@mfleisz mfleisz merged commit 6aa9143 into FreeRDP:master Dec 13, 2017

1 check passed

jenkins: PullRequestTester Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment