New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xrandr and fixes #4332

Merged
merged 4 commits into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@hardening
Contributor

hardening commented Dec 23, 2017

Fixes for #4330 and #4324.

hardening added some commits Dec 22, 2017

Use more xrandr attributes when available and preserve [desktop|devic…
…e]ScaleFactor

Fix a too restrictive detection of XRandr support.
Set more monitor's attributes like physical size and orientation when XRandr is
available.
Set [desktop|device]ScaleFactor when it has been given on the command line, this
should fix #4324.
Fix for #4330
Since ec027bf dynamic resolution is broken when used with egfx. Before that commit
we were tracking a server sent resize by setting a DesktopResize callback. This callback
is called when the desktop is resized by the server. Anyway the problem was that when this
callback is called, the activation sequence is not always completed, which were leading to
some freeze with 2012r2 servers (sending packets before the sequence is finished).
So with the faulty commit, we are tracking server resizes by subscribing to the Actived
event, that is called at the end of a reactivation sequence, so we're sure to not send packets
when not fully activated.
Anyway the issue that shows on (#4330) is that when you use egfx, no reactivation sequence happens,
the server only sends a ResetGraphics message with the new size, and so we miss the resized event.
This fix introduces a new GraphicsReset event, makes the display channel subscribe to that event,
and react accordingly.
@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 23, 2017

Build finished.

@freerdp-bot

This comment has been minimized.

freerdp-bot commented Dec 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/2504/

@akallabeth

LGTM

@hardening

This comment has been minimized.

Contributor

hardening commented Dec 28, 2017

anyone to merge this one ?

@akallabeth akallabeth merged commit 4077d55 into FreeRDP:master Jan 8, 2018

1 check passed

jenkins: PullRequestTester Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment