Jump to conversation
Unresolved conversations (4)
@hardening hardening Apr 3, 2020
Perhaps you could include my patch (gist sent on IRC), as it fixes the fact that you can announce a small `pduLength` but decoding functions will be able to read more than `pduLength` (because they do checks with `Stream_GetRemainingLength(mainStream)`)
libfreerdp/core/rdp.c
@hardening hardening Apr 3, 2020
suggestion: here instead of printing the offset which is useless we could just show the remaining bytes...
libfreerdp/core/capabilities.c
akallabeth nfedera
@bmiklautz bmiklautz Apr 2, 2020
What's the reason for the len < 4?
libfreerdp/core/rdp.c
akallabeth
@bmiklautz bmiklautz Apr 2, 2020
I might misinterpret the spec but a length of 0 could be possible (2.2.9.2.1.1 Extended Bitmap Data ).
libfreerdp/core/orders.c
akallabeth
Resolved conversations (2)
@nfedera nfedera Apr 6, 2020
probably that should have been `length - rest, length` (as in offset) but like above, I'd just print the `rest` bytes not handled.
Outdated
libfreerdp/core/capabilities.c
akallabeth
@hardening hardening Apr 3, 2020
length should be checked (if it's less than 4)
libfreerdp/core/capabilities.c
hardening