Connection search doesn't work #773

Closed
danboid opened this Issue Feb 25, 2016 · 9 comments

Projects

None yet

3 participants

@danboid
danboid commented Feb 25, 2016

I've noticed that if I push CTRL+f in the main remmina connection list window a search box appears but it doesn't work. If I type (part of) the name or address of a server that I can see exists within remmina (but isn't currently highlighted) remmina doesn't highlight it when I push enter as I'd expect.

@danboid
danboid commented Feb 25, 2016

remmina 1.2.0rcgit.8-1 under Arch x64

@antenore
Member
antenore commented Mar 8, 2016

The search box is intended to filter (reduce) the list of server while you are typing, is not intended to automatically select a server from the list.

So, if you type something in the search box the list is actually filtered, the search box is working as expected, otherwise there is really a problem.

When you have filtered the list, if you don't want to remove the hands from your keyboard you can maybe use the TAB key till you reach the server list.

Can you please confirm? If you would like an enhancement can you please edit your first message adding more details?

Thanks

@antenore antenore added the notabug label Mar 8, 2016
@antenore antenore self-assigned this Mar 8, 2016
@danboid
danboid commented Mar 8, 2016

Hi Antenore

Unfortunately the search doesn't work in the way you describe either. All of the servers/connections are displayed as I type stuff that should reduce the displayed selection.

@giox069
Contributor
giox069 commented Mar 8, 2016

You are referring to two different search boxes: @antenore is referring to the one on the taskbar, hidden by default. You can enable using a menu option.
@danboid is referring to the standard GTK searchbox which appears when pressing CTRL+F on a list.

@antenore: I think we can try to disable the standard GTK search box on the list, if possible. So users does not get confused.

@antenore
Member
antenore commented Mar 8, 2016

Bizarre, if I have the Quick Search activated, when I hit ctrl+f the cursor is placed automatically inside it.

Sure we can set it to OFF?

Now I understood, let me take a look. Thanks @giox069

@giox069
Contributor
giox069 commented Mar 8, 2016

I cannot try now, but I can remember that the standard GTK search box appears when you type some alphanumeric char inside the profile list box. I never used CTRL+F to make it appear.

@antenore
Member
antenore commented Mar 8, 2016

Solved, I'm committing and merging

@antenore antenore added a commit that referenced this issue Mar 8, 2016
@antenore antenore Add accelerator ctrl+f to Quick Search to avoid the standard Gnome/GT…
…K search popoup. Closes #773
c373ef9
@antenore
Member
antenore commented Mar 8, 2016

@danboid are you able to test the PR #788 ?
Otherwise I can merge it as in any case break the normal Remmina functionalities.

@giox069 Do you agree? I just added an accelerator in the glade file.

@antenore antenore closed this in #788 Mar 8, 2016
@antenore
Member
antenore commented Mar 8, 2016

@danboid tomorrow you should have it in Arch (even now I think), let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment