Feature Request: After Command #746 #748

Merged
merged 2 commits into from Jan 28, 2016

Projects

None yet

2 participants

@antenore
Member

This patch provides a means to execute a command (or a script) just after a connection close.
This complete and improve the #553 request

There are some minor issues that will be addressed in a following release, like arguments parsing.

@antenore
Member

Merging it, if you guys see something bad don't hesitate to roll it back.

@giox069 @dktrkranz @weberhofer

@antenore antenore merged commit 9c912eb into next Jan 28, 2016
@weberhofer weberhofer added a commit to weberhofer/Remmina that referenced this pull request Jan 29, 2016
@weberhofer weberhofer adjust lenght of strings
These change fixes a buffer-overflow introduced in #748
cc7bb7d
@weberhofer
Collaborator

Fixed a problem in #749

[  107s] In file included from /usr/include/string.h:636:0,
[  107s]                  from /usr/include/glib-2.0/glib/gi18n.h:24,
[  107s]                  from /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:37:
[  107s] In function 'strcpy',
[  107s]     inlined from 'remmina_plugin_cmdexec_new' at /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:72:8:
[  107s] /usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]
[  107s]    return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
[  107s]    ^
[  107s] In function 'strcpy',
[  107s]     inlined from 'remmina_plugin_cmdexec_new' at /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:73:8:
[  107s] /usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]
[  107s]    return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
[  107s]    ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment