New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: After Command #746 #748

Merged
merged 2 commits into from Jan 28, 2016

Conversation

Projects
None yet
2 participants
@antenore
Member

antenore commented Jan 27, 2016

This patch provides a means to execute a command (or a script) just after a connection close.
This complete and improve the #553 request

There are some minor issues that will be addressed in a following release, like arguments parsing.

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore Jan 28, 2016

Member

Merging it, if you guys see something bad don't hesitate to roll it back.

@giox069 @dktrkranz @weberhofer

Member

antenore commented Jan 28, 2016

Merging it, if you guys see something bad don't hesitate to roll it back.

@giox069 @dktrkranz @weberhofer

antenore added a commit that referenced this pull request Jan 28, 2016

Merge pull request #748 from FreeRDP/postcommands
Feature Request: After Command #746

@antenore antenore merged commit 9c912eb into next Jan 28, 2016

@weberhofer

This comment has been minimized.

Show comment
Hide comment
@weberhofer

weberhofer Jan 29, 2016

Collaborator

Fixed a problem in #749

[  107s] In file included from /usr/include/string.h:636:0,
[  107s]                  from /usr/include/glib-2.0/glib/gi18n.h:24,
[  107s]                  from /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:37:
[  107s] In function 'strcpy',
[  107s]     inlined from 'remmina_plugin_cmdexec_new' at /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:72:8:
[  107s] /usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]
[  107s]    return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
[  107s]    ^
[  107s] In function 'strcpy',
[  107s]     inlined from 'remmina_plugin_cmdexec_new' at /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:73:8:
[  107s] /usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]
[  107s]    return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
[  107s]    ^
Collaborator

weberhofer commented Jan 29, 2016

Fixed a problem in #749

[  107s] In file included from /usr/include/string.h:636:0,
[  107s]                  from /usr/include/glib-2.0/glib/gi18n.h:24,
[  107s]                  from /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:37:
[  107s] In function 'strcpy',
[  107s]     inlined from 'remmina_plugin_cmdexec_new' at /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:72:8:
[  107s] /usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]
[  107s]    return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
[  107s]    ^
[  107s] In function 'strcpy',
[  107s]     inlined from 'remmina_plugin_cmdexec_new' at /home/abuild/rpmbuild/BUILD/Remmina-1.1.99.git.20160128/remmina/src/remmina_plugin_cmdexec.c:73:8:
[  107s] /usr/include/bits/string3.h:104:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer [enabled by default]
[  107s]    return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
[  107s]    ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment