New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin with basic support for the SPICE protocol #870

Merged
merged 3 commits into from May 22, 2016

Conversation

Projects
None yet
3 participants
@larchunix
Collaborator

larchunix commented May 21, 2016

Hi,

Here is an implementation of a SPICE plugin (requested in #117).

As a first step, only basic features have been implemented.

It has been tested on ArchLinux using spice-client-gtk3 and the Xspice server from package xf86-video-qxl.

Please review.

@giox069

This comment has been minimized.

Show comment
Hide comment
@giox069

giox069 May 22, 2016

Contributor

Hi @larchunix, many thanks for contributing to remmina.

Compilation
I can compile this PR on arch, but not under Ubuntu 16.04.
Under ubuntu I installed libspice-client-gtk-3.0-dev libspice-protocol-dev spice-protocol spice-client-gtk. CMake output says:

-- Finding suggested package SPICE.
--   Disable this using "-DWITH_SPICE=OFF".
-- Checking for module 'spice-protocol'
--   Found spice-protocol, version 0.12.10
-- Checking for module 'spice-client-gtk-3.0'
--   Found spice-client-gtk-3.0, version 0.30

But then, compilation fails with
fatal error: spice-client-gtk.h: No such file or directory

Any ideas to fix this and help me compile ? :)

SSH
Since the plugin does not support the integrated remmina ssh tunnel (remmina_plugin_service->protocol_plugin_start_direct_tunnel()), you are invited to use that function. Or, as a quick fix, remove the SSH configuration page by zeoring "REMMINA_PROTOCOL_SSH_SETTING_TUNNEL" the in remmina_plugin_spice struct.

Contributor

giox069 commented May 22, 2016

Hi @larchunix, many thanks for contributing to remmina.

Compilation
I can compile this PR on arch, but not under Ubuntu 16.04.
Under ubuntu I installed libspice-client-gtk-3.0-dev libspice-protocol-dev spice-protocol spice-client-gtk. CMake output says:

-- Finding suggested package SPICE.
--   Disable this using "-DWITH_SPICE=OFF".
-- Checking for module 'spice-protocol'
--   Found spice-protocol, version 0.12.10
-- Checking for module 'spice-client-gtk-3.0'
--   Found spice-client-gtk-3.0, version 0.30

But then, compilation fails with
fatal error: spice-client-gtk.h: No such file or directory

Any ideas to fix this and help me compile ? :)

SSH
Since the plugin does not support the integrated remmina ssh tunnel (remmina_plugin_service->protocol_plugin_start_direct_tunnel()), you are invited to use that function. Or, as a quick fix, remove the SSH configuration page by zeoring "REMMINA_PROTOCOL_SSH_SETTING_TUNNEL" the in remmina_plugin_spice struct.

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 22, 2016

Collaborator

Thanks for your feedback.

I have updated the PR:

  • conditional include (should fix the compilation issues on ubuntu),
  • replaced REMMINA_PROTOCOL_SSH_SETTING_TUNNEL by REMMINA_PROTOCOL_SSH_SETTING_NONE for now.
Collaborator

larchunix commented May 22, 2016

Thanks for your feedback.

I have updated the PR:

  • conditional include (should fix the compilation issues on ubuntu),
  • replaced REMMINA_PROTOCOL_SSH_SETTING_TUNNEL by REMMINA_PROTOCOL_SSH_SETTING_NONE for now.
@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 22, 2016

Member

Thanks a lot @larchunix !!!

Member

antenore commented May 22, 2016

Thanks a lot @larchunix !!!

@giox069 giox069 merged commit 5e84b32 into FreeRDP:next May 22, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@giox069

This comment has been minimized.

Show comment
Hide comment
@giox069

giox069 May 22, 2016

Contributor

Merged! @larchunix thank you very much, we will add you to the contributors list as soon as possible.
We also wait for some improvements: for example connection failure and wrong password is not currently detected. It should be detected and reported to the user.
Thank you again.

Contributor

giox069 commented May 22, 2016

Merged! @larchunix thank you very much, we will add you to the contributors list as soon as possible.
We also wait for some improvements: for example connection failure and wrong password is not currently detected. It should be detected and reported to the user.
Thank you again.

antenore added a commit that referenced this pull request May 24, 2016

@antenore antenore added this to the v1.2.1 milestone Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment