New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SPICE plugin improvements #874

Merged
merged 3 commits into from May 23, 2016

Conversation

Projects
None yet
2 participants
@larchunix
Collaborator

larchunix commented May 23, 2016

Hi,

Here are more improvements for the SPICE plugin:

  • Fix a memory leak for the SpiceSession,
  • Run the authentication dialog if the password is wrong or missing,
  • Add the SPICE protocol to the quick connect list.

Regards.

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 23, 2016

Member

Good job, so now spice is in the quick connect protocol list. :-)

Member

antenore commented May 23, 2016

Good job, so now spice is in the quick connect protocol list. :-)

@antenore antenore merged commit 779f70a into FreeRDP:next May 23, 2016

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 23, 2016

Member

@giox069 tested and merged

Member

antenore commented May 23, 2016

@giox069 tested and merged

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 23, 2016

Member

@larchunix I had a seg fault, I'm investigating.

I'll open an issue to keep track of it.

Member

antenore commented May 23, 2016

@larchunix I had a seg fault, I'm investigating.

I'll open an issue to keep track of it.

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 23, 2016

Collaborator

@antenore Keep me informed if you manage to reproduce it.

Collaborator

larchunix commented May 23, 2016

@antenore Keep me informed if you manage to reproduce it.

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 23, 2016

Member

On FreeBSD I cannot make it working.

I attach a core dump just in case, but I don't see a problem in your remmina code but in the spice version that comes with FreeBSD.

gdb.txt

At the moment I'll just leave this as reference, what do you think?

Member

antenore commented May 23, 2016

On FreeBSD I cannot make it working.

I attach a core dump just in case, but I don't see a problem in your remmina code but in the spice version that comes with FreeBSD.

gdb.txt

At the moment I'll just leave this as reference, what do you think?

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 24, 2016

Collaborator

Could you try to open a SPICE connection using vinagre on FreeBSD ?

Collaborator

larchunix commented May 24, 2016

Could you try to open a SPICE connection using vinagre on FreeBSD ?

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 24, 2016

Member

Yesterday I've tried with Spicy (the official GTK SPICE client) and it works, I don't know if I can easily try with vinagre because one of it's dependencies is FreeRDP, that on FreeBSD is too old.

I'll try ASAP, meanwhile I open an issue.

Member

antenore commented May 24, 2016

Yesterday I've tried with Spicy (the official GTK SPICE client) and it works, I don't know if I can easily try with vinagre because one of it's dependencies is FreeRDP, that on FreeBSD is too old.

I'll try ASAP, meanwhile I open an issue.

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 24, 2016

Collaborator

If spicy works, it is most likely an issue with my code but I don't have a FreeBSD installation to figure out where the problem is.

Collaborator

larchunix commented May 24, 2016

If spicy works, it is most likely an issue with my code but I don't have a FreeBSD installation to figure out where the problem is.

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 24, 2016

Member

I'll take a look as well.
In few days I'll also update the AUTHORS file.

Member

antenore commented May 24, 2016

I'll take a look as well.
In few days I'll also update the AUTHORS file.

@antenore antenore added this to the v1.2.1 milestone Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment