New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remmina Main Window Refactoring #875

Merged
merged 56 commits into from May 30, 2016

Conversation

Projects
None yet
5 participants
@antenore
Member

antenore commented May 23, 2016

This PR brings a new Remmina Main window using an header bar

remmina_main

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 27, 2016

Member

This adhere more to the Gnome guidelines

With the Search Bar Deactivated:

selection_145

With the Bar activated.

selection_144

@giox069 , should we update the poll on G+ ?

Member

antenore commented May 27, 2016

This adhere more to the Gnome guidelines

With the Search Bar Deactivated:

selection_145

With the Bar activated.

selection_144

@giox069 , should we update the poll on G+ ?

@giox069

This comment has been minimized.

Show comment
Hide comment
@giox069

giox069 May 27, 2016

Contributor

I liked a lot the previous version with the search bar always visible on the first row. Searching, in my daily use, is done very frequently, at each connection. Hiding the search bar is not very useful: I have an extra button shown, I have to unhide it, I lose one line of space. Search, in Remmina, is not an option for me, it's daily life.

If a user does not uses search... he/she could simply ignore it ?

About the G+ poll: we still have too few users and I don't think we will be useful to make a poll now... but it's just another personal opinion. The community is slowly growing, and this is good.

Contributor

giox069 commented May 27, 2016

I liked a lot the previous version with the search bar always visible on the first row. Searching, in my daily use, is done very frequently, at each connection. Hiding the search bar is not very useful: I have an extra button shown, I have to unhide it, I lose one line of space. Search, in Remmina, is not an option for me, it's daily life.

If a user does not uses search... he/she could simply ignore it ?

About the G+ poll: we still have too few users and I don't think we will be useful to make a poll now... but it's just another personal opinion. The community is slowly growing, and this is good.

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 27, 2016

Member

I liked a lot the previous version with the search bar always visible on the first row. Searching, in my daily use, is done very frequently, at each connection. Hiding the search bar is not very useful: I have an extra button shown, I have to unhide it, I lose one line of space. Search, in Remmina, is not an option for me, it's daily life.

By default is already unhide, hiding the search bar is an option not the standard. So you can consider just the second screenshot.

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

Moreover consider that I've removed completely the window decoration, so you lost one line but you got a new one, so you have lost zero at the end.

I'm undecided, I let you all decide because I really don't know.

Personally I like more this last solution as it is much more "compliant" and easier to code.

Member

antenore commented May 27, 2016

I liked a lot the previous version with the search bar always visible on the first row. Searching, in my daily use, is done very frequently, at each connection. Hiding the search bar is not very useful: I have an extra button shown, I have to unhide it, I lose one line of space. Search, in Remmina, is not an option for me, it's daily life.

By default is already unhide, hiding the search bar is an option not the standard. So you can consider just the second screenshot.

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

Moreover consider that I've removed completely the window decoration, so you lost one line but you got a new one, so you have lost zero at the end.

I'm undecided, I let you all decide because I really don't know.

Personally I like more this last solution as it is much more "compliant" and easier to code.

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 27, 2016

Collaborator

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

When I have suggested to center the quick connect widget I didn't realize it would be this painful. It's not worth it to spend so much effort on it.

Collaborator

larchunix commented May 27, 2016

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

When I have suggested to center the quick connect widget I didn't realize it would be this painful. It's not worth it to spend so much effort on it.

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 27, 2016

Member

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

When I have suggested to center the quick connect widget I didn't realize it would be this painful. It's not worth it to spend so much effort on it.

Yes, but now I like more this way :-/ is it that bad compared to the first version?

The design pattern is: https://developer.gnome.org/hig/stable/search.html.en

Sorry to bother you all guys !!!! (ToT)/

Member

antenore commented May 27, 2016

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

When I have suggested to center the quick connect widget I didn't realize it would be this painful. It's not worth it to spend so much effort on it.

Yes, but now I like more this way :-/ is it that bad compared to the first version?

The design pattern is: https://developer.gnome.org/hig/stable/search.html.en

Sorry to bother you all guys !!!! (ToT)/

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 27, 2016

Collaborator

I'm fine with the second screenshot (according to the design pattern, the searchbar hide/unhide button should be on the right and the text should be removed).

Collaborator

larchunix commented May 27, 2016

I'm fine with the second screenshot (according to the design pattern, the searchbar hide/unhide button should be on the right and the text should be removed).

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 27, 2016

Member

selection_153

Like this should be fine for everybody I think. We just need to fix a weird performance issue.

Member

antenore commented May 27, 2016

selection_153

Like this should be fine for everybody I think. We just need to fix a weird performance issue.

@larchunix

This comment has been minimized.

Show comment
Hide comment
@larchunix

larchunix May 27, 2016

Collaborator

Well done!

Collaborator

larchunix commented May 27, 2016

Well done!

@antenore antenore added this to the v1.2.0 milestone May 27, 2016

@antenore antenore self-assigned this May 27, 2016

@giox069

This comment has been minimized.

Show comment
Hide comment
@giox069

giox069 May 28, 2016

Contributor

Very good!

Contributor

giox069 commented May 28, 2016

Very good!

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore May 30, 2016

Member

Tested the last @giox069 fixes (thanks!!!).

Everything is fine. I merge this and I'm preparing for a new release.

Member

antenore commented May 30, 2016

Tested the last @giox069 fixes (thanks!!!).

Everything is fine. I merge this and I'm preparing for a new release.

@antenore antenore merged commit cd46bc9 into next May 30, 2016

@antenore antenore deleted the remmina_main branch May 30, 2016

@Chugajstyr

This comment has been minimized.

Show comment
Hide comment
@Chugajstyr

Chugajstyr Jun 3, 2016

Previous Remmina main interface is not available now? Any chance it will be accessible as an option? I get used to it))).

Chugajstyr commented Jun 3, 2016

Previous Remmina main interface is not available now? Any chance it will be accessible as an option? I get used to it))).

@antenore

This comment has been minimized.

Show comment
Hide comment
@antenore

antenore Jun 3, 2016

Member

I'm sorry @Chugajstyr but we cannot support two different interfaces.

Unlucky it's not like desktop theme. The modifications we have done are deep in the code.

We discussed these changes between us and openly with the community before to commit them.

Beside usability reasons and beside the fact that we like a lot this new interface , Gnome is clearly taking this direction in terms of layout and as Remmina is (still? yet?) a GTK+ application we have to follow the wave or one day Remmina won't work and/or integrate in a GTK+ environment.

I understand your discomfort and I'm sorry for this, but we cannot do that much.

Please don't hesitate to open new issues or comment to existing ones, when it makes sense we will do our best to support you.

Member

antenore commented Jun 3, 2016

I'm sorry @Chugajstyr but we cannot support two different interfaces.

Unlucky it's not like desktop theme. The modifications we have done are deep in the code.

We discussed these changes between us and openly with the community before to commit them.

Beside usability reasons and beside the fact that we like a lot this new interface , Gnome is clearly taking this direction in terms of layout and as Remmina is (still? yet?) a GTK+ application we have to follow the wave or one day Remmina won't work and/or integrate in a GTK+ environment.

I understand your discomfort and I'm sorry for this, but we cannot do that much.

Please don't hesitate to open new issues or comment to existing ones, when it makes sense we will do our best to support you.

@Chugajstyr

This comment has been minimized.

Show comment
Hide comment
@Chugajstyr

Chugajstyr Jun 4, 2016

Its ok, @antenore, Iam appreciate Your work on improving Remmina, it`s features & usabilty. I too much used to this thing in all, to give up because of the lost toolbar))).

Chugajstyr commented Jun 4, 2016

Its ok, @antenore, Iam appreciate Your work on improving Remmina, it`s features & usabilty. I too much used to this thing in all, to give up because of the lost toolbar))).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment