[BUG] Missing cast ( BaseType_t ) on portGET_CORE_ID

[mike919192]

Describe the bug
I have been going through my custom SMP port and cleaning up warnings. I believe there is a missing ( BaseType_t ) cast in the kernel code here. Every other use of portGET_CORE_ID() in tasks.c has this cast.

My portGET_CORE_ID() implementation returns unsigned int. I followed the example of the RP2040 port which also returns the same type.

The warning message:

portmacro.h:106:34: warning: conversion to 'BaseType_t' {aka 'const long int'} from 'unsigned int' may change the sign of the result [-Wsign-conversion]
  106 |     #define portGET_CORE_ID()    get_core_num()
      |                                  ^~~~~~~~~~~~
tasks.c:896:43: note: in expansion of macro 'portGET_CORE_ID'
  896 |         const BaseType_t xCurrentCoreID = portGET_CORE_ID();

Target

• Development board: Avnet Microzed
• Instruction Set Architecture: armv7
• IDE and version: Xilinx Vitis 2024.2
• Toolchain and version: arm-none-eabi-gcc13.3.0

Host

• Host OS: Windows
• Version: 10

[aggarg]

My portGET_CORE_ID() implementation returns unsigned int.

You should change it to return BaseType_t as that is what the code expects and there is no reason not to do so. Having said that, adding the cast you mentioned is harmless too. Would you be willing to raise a PR?

[mike919192]

My portGET_CORE_ID() implementation returns unsigned int.

You should change it to return BaseType_t as that is what the code expects and there is no reason not to do so. Having said that, adding the cast you mentioned is harmless too. Would you be willing to raise a PR?

Its no problem to make my function return BaseType_t. I was following the example of the RP2040 port as a 'known good implementation' which returns unsigned int.

The only reason I raised the issue, is that there is one use of portGET_CORE_ID that is missing the cast (this one). Every other use that I see has the cast (example).

I can make a PR, I just wanted to be sure first that it looks like the cast was intended to be there.