From c6a02372b6437db2b17ad3fc9ba1d08f7506c018 Mon Sep 17 00:00:00 2001 From: absidue <48293849+absidue@users.noreply.github.com> Date: Mon, 22 May 2023 22:07:40 +0200 Subject: [PATCH] Fix keyboard shortcut to toggle the captions --- .../components/ft-video-player/ft-video-player.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/renderer/components/ft-video-player/ft-video-player.js b/src/renderer/components/ft-video-player/ft-video-player.js index f285e312a68c..c93a715e0ebc 100644 --- a/src/renderer/components/ft-video-player/ft-video-player.js +++ b/src/renderer/components/ft-video-player/ft-video-player.js @@ -1319,13 +1319,16 @@ export default defineComponent({ }, toggleCaptions: function () { - const tracks = this.player.textTracks().tracks_ - - if (tracks.length > 1) { - if (tracks[1].mode === 'showing') { - tracks[1].mode = 'disabled' + // skip videojs-http-streaming's segment-metadata track + // https://github.com/videojs/http-streaming#segment-metadata + const trackIndex = this.useDash ? 1 : 0 + + const tracks = this.player.textTracks() + if (tracks.length > trackIndex) { + if (tracks[trackIndex].mode === 'showing') { + tracks[trackIndex].mode = 'disabled' } else { - tracks[1].mode = 'showing' + tracks[trackIndex].mode = 'showing' } } },