Bounty Hunter abilities

[paulosaramp]

1st ability needs work, 2nd ability completed, 3rd and 4th are placeholders

Progress for #2147

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 11, 2023 1:55pm

[ghost]

👇 Click on the image for a new way to code review

Legend

[DreadKnight]

@paulosaramp Alright, will review this again soon and see about merging if all good or provide you with feedback. Hopefully you'll be able to poke at any possible encountered issues if that's the case, we'll have to see pretty soon.

Will turn Bounty Hunter issue into a meta issue, so that each ability can be poked individually. It actually happened like this before for quite a few of the units; whatever it takes to get progress done :)

[DreadKnight]

@paulosaramp I've updated original post to be a tad less cryptic and confusing.

I've tested this and it works pretty well. Some feedback:

• passive should only trigger a message log if enemy in personal space, without the "enemy in" or "no one" extra stuff, as we're trying to keep those logs small; will probably increase the box soon to make this an one liner & some others
• would be nice if the extra attack when killing target would be performed after a small delay, to be way less confusing
• comment consistency would be nice (// Kinda like this one), what I mean is space after slashes and capitalized letter

Let me know if you can make the tweaks within 2 weeks or so, otherwise will merge and open new issues. You can also set the unit playable to true, as we have better separated branches now and we'll also have this implemented soon™ #2184

[paulosaramp]

alright i'll see what i can do

[DreadKnight]

Fixed the comments and opened two new issues, #2198 #2199, so that I can merge this.
You're eligible for XatteR bounty and the new issues have bounties as well.