From 529e347a9b04c9b8a27a7b47648d4f44b6ab1225 Mon Sep 17 00:00:00 2001 From: Martin Geno Date: Wed, 8 Nov 2017 17:28:17 +0100 Subject: [PATCH] add global measurment for autoupdater --- database/influxdb/database.go | 15 ++++++++------- database/influxdb/global.go | 1 + database/influxdb/global_test.go | 2 ++ runtime/stats.go | 17 +++++++++++++---- runtime/stats_test.go | 13 +++++++++++++ 5 files changed, 37 insertions(+), 11 deletions(-) diff --git a/database/influxdb/database.go b/database/influxdb/database.go index 6239916a..b8e99d1c 100644 --- a/database/influxdb/database.go +++ b/database/influxdb/database.go @@ -12,13 +12,14 @@ import ( ) const ( - MeasurementLink = "link" // Measurement for per-link statistics - MeasurementNode = "node" // Measurement for per-node statistics - MeasurementGlobal = "global" // Measurement for summarized global statistics - CounterMeasurementFirmware = "firmware" // Measurement for firmware statistics - CounterMeasurementModel = "model" // Measurement for model statistics - batchMaxSize = 500 - batchTimeout = 5 * time.Second + MeasurementLink = "link" // Measurement for per-link statistics + MeasurementNode = "node" // Measurement for per-node statistics + MeasurementGlobal = "global" // Measurement for summarized global statistics + CounterMeasurementFirmware = "firmware" // Measurement for firmware statistics + CounterMeasurementModel = "model" // Measurement for model statistics + CounterMeasurementAutoupdater = "autoupdater" // Measurement for autoupdater + batchMaxSize = 500 + batchTimeout = 5 * time.Second ) type Connection struct { diff --git a/database/influxdb/global.go b/database/influxdb/global.go index 26d27bb2..0a302d5d 100644 --- a/database/influxdb/global.go +++ b/database/influxdb/global.go @@ -12,6 +12,7 @@ func (conn *Connection) InsertGlobals(stats *runtime.GlobalStats, time time.Time conn.addPoint(MeasurementGlobal, nil, GlobalStatsFields(stats), time) conn.addCounterMap(CounterMeasurementModel, stats.Models, time) conn.addCounterMap(CounterMeasurementFirmware, stats.Firmwares, time) + conn.addCounterMap(CounterMeasurementAutoupdater, stats.Autoupdater, time) } // GlobalStatsFields returns fields for InfluxDB diff --git a/database/influxdb/global_test.go b/database/influxdb/global_test.go index f1ced757..5f43eb5a 100644 --- a/database/influxdb/global_test.go +++ b/database/influxdb/global_test.go @@ -37,6 +37,8 @@ func createTestNodes() *runtime.Nodes { }, } nodeData.Nodeinfo.Software.Firmware.Release = "2016.1.6+entenhausen1" + nodeData.Nodeinfo.Software.Autoupdater.Enabled = true + nodeData.Nodeinfo.Software.Autoupdater.Branch = "stable" nodes.AddNode(nodeData) nodes.AddNode(&runtime.Node{ diff --git a/runtime/stats.go b/runtime/stats.go index a4773037..29e6562c 100644 --- a/runtime/stats.go +++ b/runtime/stats.go @@ -1,5 +1,7 @@ package runtime +const DISABLED_AUTOUPDATER = "disabled" + // CounterMap to manage multiple values type CounterMap map[string]uint32 @@ -12,15 +14,17 @@ type GlobalStats struct { Gateways uint32 Nodes uint32 - Firmwares CounterMap - Models CounterMap + Firmwares CounterMap + Models CounterMap + Autoupdater CounterMap } //NewGlobalStats returns global statistics for InfluxDB func NewGlobalStats(nodes *Nodes) (result *GlobalStats) { result = &GlobalStats{ - Firmwares: make(CounterMap), - Models: make(CounterMap), + Firmwares: make(CounterMap), + Models: make(CounterMap), + Autoupdater: make(CounterMap), } nodes.RLock() @@ -39,6 +43,11 @@ func NewGlobalStats(nodes *Nodes) (result *GlobalStats) { if info := node.Nodeinfo; info != nil { result.Models.Increment(info.Hardware.Model) result.Firmwares.Increment(info.Software.Firmware.Release) + if info.Software.Autoupdater.Enabled { + result.Autoupdater.Increment(info.Software.Autoupdater.Branch) + } else { + result.Autoupdater.Increment(DISABLED_AUTOUPDATER) + } } } } diff --git a/runtime/stats_test.go b/runtime/stats_test.go index 0a4ace42..c2bbecd3 100644 --- a/runtime/stats_test.go +++ b/runtime/stats_test.go @@ -24,6 +24,10 @@ func TestGlobalStats(t *testing.T) { // check firmwares assert.Len(stats.Firmwares, 1) assert.EqualValues(1, stats.Firmwares["2016.1.6+entenhausen1"]) + + // check autoupdater + assert.Len(stats.Autoupdater, 2) + assert.EqualValues(1, stats.Autoupdater["stable"]) } func createTestNodes() *Nodes { @@ -58,6 +62,15 @@ func createTestNodes() *Nodes { Hardware: data.Hardware{ Model: "TP-Link 841", }, + Software: data.Software{ + Autoupdater: struct { + Enabled bool `json:"enabled,omitempty"` + Branch string `json:"branch,omitempty"` + }{ + Enabled: true, + Branch: "stable", + }, + }, }, })