New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache for non-ports is not created / cleared correctly #56

Open
dlangille opened this Issue Oct 31, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@dlangille
Contributor

dlangille commented Oct 31, 2017

I discovered this for /UPDATING

The cache is being created in head/UPDATING - should be UPDATING

There is nothing which clears cache for non-ports (e.g. Mk/Uses/cargo.mk)

@dlangille

This comment has been minimized.

Contributor

dlangille commented Nov 1, 2017

I suspect scripts/cache.pm can be removed from the code base.

All cache clearing is handled by triggers on the database.

@dlangille

This comment has been minimized.

Contributor

dlangille commented Jan 21, 2018

I wonder if this is related to the split in observer_commits.pm?

my ($subtree, $category_name, $port_name, $extra) = split/\//,$filename, 4;

Example code:

#!/usr/local/bin/perl

my $filename = '/ports/head/sysutils/k3b-kde4/files/patch-git_d5b1016';
my ($subtree, $category_name, $port_name, $extra) = split/\//,$filename, 4;

print "'$subtree', '$category_name', '$port_name', '$extra'\n";

Sample output:

$ perl ~/tmp/split.pl
'', 'ports', 'head', 'sysutils/k3b-kde4/files/patch-git_d5b1016'

This is clearly wrong. I suspect that needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment