Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for testing /dev before version 1.7 #1548

Closed
Alkarex opened this issue May 26, 2017 · 21 comments

Comments

Projects
None yet
6 participants
@Alkarex
Copy link
Member

commented May 26, 2017

The future version 1.7 of FreshRSS is ready for testing. This time, the main theme has been to introduce a more more natural order of entries when refreshing feeds, but there is also a number of new features and bug corrections, as visible in the changelog:

  • Features:
    • Deferred insertion of new articles, for better chronological order #530
    • Better search:
      • Possibility to use multiple intitle:, inurl:, author: #1478
      • Negative searches with ! or - #1381
        • Examples: !intitle:unwanted, -intitle:unwanted, -inurl:unwanted, -author:unwanted, -#unwanted, -unwanted
      • Allow double-quotes, such as author:"some name", in addition to single-quotes such as author:'some name' #1478
    • Multi-user tokens (to access RSS outputs of any user) #1390
  • Compatibility:
    • Add support for PHP 7.1 #1471
    • PostgreSQL is not experimental anymore #1476
  • Bug fixing
    • Fix PubSubHubbub bugs when deleting users, and improved behaviour when removing feeds #1495
    • Fix SQL uniqueness bug with PostgreSQL #1476
      • (Require manual update for existing installations)
    • Do not require PHP extension fileinfo for favicons #1461
    • Fix UI lowest subscription popup hidden #1479
    • Fix update system via ZIP archive #1498
    • Work around for IE / Edge bug in username pattern in version 1.6.3 #1511
    • Fix mark as read articles when adding a new feed #1535
    • Change load order of CSS and JS to help CustomCSS and CustomJS extensions Extensions#13, #1547
  • UI
    • New option for not closing the article when clicking outside its area #1539
    • Download icon 💾 for other MIME types (e.g. application/*) #1522
  • I18n
  • Security
    • Do not require write access to check availability of new versions #1450
  • Misc.
    • Move documentation into FreshRSS code #1510
    • Moved ./data/force-https.default.txt to ./force-https.default.txt,
      ./data/config.default.php to ./config.default.php,
      and ./data/users/_/config.default.php to ./config-user.default.php #1531
    • Fall back to article URL when the article GUID is empty #1482
    • Rewritten Favicon library using cURL #1504
    • Fix SimplePie option to disable syslog #1528

You are all kindly invited to give a try to the /dev version. (@Frenzie, @vonv, @Wanabo, @lapineige, @ecmu, @danc, @plarus...)

Many thanks already to those of you who have contributed code ( @marienfressinaud, @jlefler, @gsongsong, @cez81, @psukys, @hoilc ), and to those of you who been involved one way or another in this new version, such as @aledeg, @Trim, @Silviojjb, @Pazns, @Jedediah04, @sant527, @lapineige, @tcitworld, @uncovery, @Crupuk, @neuralcpu , @GeoZzNL, @kevinpapst, @FordDoctor, @peugnezb, @Mayson74, @LeapingDragon, @oupala, @disanvparean, @angristan, @Alwaysin, @gabrielcossette, etc.

@Alkarex Alkarex added this to the 1.7.0 milestone May 26, 2017

@Alkarex Alkarex referenced this issue May 26, 2017

Merged

Version 1.7.0 #1549

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 26, 2017

Did something change about system extensions? The ImageProxy extension seems to have stopped working and also can't be enabled/disabled. I won't have any time to look into this myself until Tuesday at the earliest.

Edit: also many of my feeds (but apparently not all) have been duplicated as new. Here's an example screenshot from http://onzetaal.nl/rss/taaladviezen/ It's not immediately obvious to me which change might be responsible. It's fairly minor but suddenly having 154 unread items does stand out a little bit.

screenshot_2017-05-26_20-04-51-fs8

Edit 2: forgot to mention, I updated from 1.6.3.

@Alkarex

This comment has been minimized.

Copy link
Member Author

commented May 26, 2017

@Frenzie For your duplicates, could it be invalid feeds providing an empty GUID? If this is the case, then FreshRSS behaviour has indeed changed to be more consistent by falling back to article URL, and if URL is empty to an article hash #1483

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 27, 2017

Ah yes, that does look like an important change as a lack of GUID doesn't make a feed invalid and is typically the same as link. However, the link hasn't actually changed or anything.

So if I understand correctly, the 1.6.x and earlier entries have their guid set to a hash in the FreshRSS db rather than the link?

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 27, 2017

Copied from FreshRSS/Extensions#16 (comment)

The actual problem [with extensions] is that there now seems to be an internal confusion between system and user extensions that didn't exist before. If you have previously enabled a user extension of the same name as a system extension you then can't disable the system extension.

@Aasemoon

This comment has been minimized.

Copy link

commented May 27, 2017

The new search capabilities are making me very happy!
And nothing seems to be broken here so far.
Cheers!

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 27, 2017

Is "Mark as read" supposed to look extra large compared to the other options?

screenshot_2017-05-27_13-02-35

Frenzie added a commit to Frenzie/Extensions that referenced this issue May 27, 2017

ImageProxy: return extension type to user
Fixes FreshRSS#16. Reverses a change that was made in relation to FreshRSS/FreshRSS#1257

The underlying cause is something slightly different, see FreshRSS/FreshRSS#1548 (comment)
@oupala

This comment has been minimized.

Copy link

commented May 27, 2017

Just testing this new version.

I manually updated the version to version 1.6.3 in constants.php :

define('FRESHRSS_VERSION', '1.6.3');

And when I check if a new version is available, I have a warning telling me that a new dev version is available. In my opinion, I should not have any warning as there is no new version on the stable channel.

There will always be a new dev version available, I want to be warned only when a new stable version is available.

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 27, 2017

Afaik if last_update.txt is set to dev then you're on the "dev channel". Perhaps there should be a more explicit way to choose between the stable and dev update channels (or at least I can't spot one at a quick glance) but I don't think the version number has or should have much of anything to do with it.

@oupala

This comment has been minimized.

Copy link

commented May 27, 2017

You seem to be right @Frenzie the channel is stored inside the last_update.txt file.

I was just following @Alkarex message which do not talk about the last_update.txt file.

@Alkarex

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

The update mechanisms (including changing channel) need to be improved. Some of it is already planned in #907

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 28, 2017

This probably isn't new as I normally just use the program without testing nooks and crannies, but if I try to look at the log then I get this error:

[Sun May 28 15:35:49.329070 2017] [:error] [pid 11823] [client asdasdfasdfasdf:39112] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 72 bytes) in /var/www/html/feeds/app/Models/LogDAO.php on line 19

I'm guessing this means there might be some recursion going on leading to a memory leak.

Edit: Sorry, I just noticed my log file is slightly hefty at 28 MiB. That probably discounts the memory leak hypothesis, but it does point to a different problem. Since 128 MiB is the standard PHP memory limit, it'd be a good idea to split up or tail the files in such a way that it doesn't happen. Or as a slightly less thorough but presumably mostly adequate solution, simply create a log.yyyy.mm.txt file for every month.

@Wanabo

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

Great to see a new dev version again!

I did a manual update. All went well, but below some remarks. I'll do some further testing and report back.

Perhaps it can be found somewhere but at first glance I could not find changed file locations in the change log. Please log this somewhere to keep the installation as clean as possible.

data
config.default.php moved to root?
force-https.txt removed?
force-https.default.txt to root?
do-install.txt check for valid database and skip install or present choice to install or go to previous installation. Now I must manually remove this file in order to get the site working again.

data\users\currentuser\log.txt was over 300 Mb. Purge once and a while? Keeping only last 10 ... 50 entries?

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 28, 2017

data\users\currentuser\log.txt was over 300 Mb. Purge once and a while? Keeping only last 10 ... 50 entries?

That sounds rather meager. I'd say you need at least a few hundred lines so you can track down something that didn't happen 10 seconds ago. Let's say 500 KiB as a default.

@Alkarex

This comment has been minimized.

Copy link
Member Author

commented May 28, 2017

Yes @Wanabo and @Frenzie, we need to have some kind of logrotate for the logs. Please open a new issue.

@Wanabo

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

@Frenzie: Any value is ok by me.

Found an issue on my installation.

Reading sort order, newest first. But as you can see in the image it is not entirely sorted by time.

sort order

Will open a new issue for log rotation.

@Wanabo

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

Issued log rotation: #1562

@Alkarex

This comment has been minimized.

Copy link
Member Author

commented May 28, 2017

@Wanabo With the new sort order, articles are sorted by declared date but only within a refresh batch. So if you have a cron job running for instance every 30 minutes, articles found during this process will be sorted by declared date. If the next cron discovers some articles with an older declared date, they will still be appended after the ones of the previous cron. See #530 for more details.

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 28, 2017

@Wanabo @Alkarex And that's good imo. Otherwise new stuff would just get lost at the bottom. You can observe this behavior even better when you add a new feed (or delete an entry directly from the db).

screenshot_2017-05-28_16-20-18-fs8

❤️

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 28, 2017

I haven't come across anything else. Looks good to me. 👍

@aledeg

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2017

So far so good :)

@Alkarex

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2017

Thank you all for the tests and good feedback. FreshRSS 1.7.0 is released :-)
https://github.com/FreshRSS/FreshRSS/releases/tag/1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.