Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show menu on mobile & other tweaks #1929

Open
wants to merge 12 commits into
base: dev
from

Conversation

Projects
None yet
3 participants
@PhieF
Copy link

commented Jun 10, 2018

Just a few tweaks for mobile devices,

I've brought the changes I've made here, as we've talked before

https://github.com/PhieF/FreshRssExtensions/tree/master/xExtension-Androidify

.flux_header .item.website span,
.item.date, .day .date,
.dropdown-menu > .no-mobile,
.no-mobile {
display: none;
}
.aside .btn-important{
margin-top:10px;

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jun 10, 2018

Member

nitpick

.flux_header .item.website span,
.item.date, .day .date,
.dropdown-menu > .no-mobile,
.no-mobile {
display: none;
}
.aside .btn-important{

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jun 10, 2018

Member

nitpick

padding-right: 10px;
}
.stick {
max-width: calc(100% - 87px);

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jun 10, 2018

Member

What is the fallback?

@Frenzie Frenzie changed the title Dev Show menu on mobile & other tweaks Jun 10, 2018

@Alkarex Alkarex added this to the 1.12.0 milestone Jun 10, 2018

@Alkarex Alkarex added the UI 🎨 label Jun 10, 2018

@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

Thanks @PhieF :-)

@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

  • Minor whitespace fixes done 94b87bd
    • Remains one Frenzie comment
  • Need to check the other themes
  • Check if the SVG icon for the menu is needed, or if the Unicode ⋮ is enough
  • Testing

Alkarex added some commits Jun 10, 2018

Use proper Unicode alternative ⋮
Vertical ellipsis (U+22EE)
Maybe the SVG icon is not needed.
@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

Hum, the new mobile view does not seem to work for me (no menus / buttons):
image

@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

For reference, the same view before the changes:
image

@PhieF

This comment has been minimized.

Copy link
Author

commented Jun 10, 2018

hm weird, what theme do you use ?
do you have the head bar usually ? before my commits

@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

I just tested with Origine

@PhieF

This comment has been minimized.

Copy link
Author

commented Jun 10, 2018

Grumpf also testing on this one, do you use to have the deconnection button, before ?
looks like the head bar is empty

@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

Ah. The disconnect button is only visible in case of "form login", and not in e.g. "HTTP login" or "No login".

@PhieF

This comment has been minimized.

Copy link
Author

commented Jun 10, 2018

Ah that may explain why, I suppose the whole header bar is hidden in that case

@PhieF

This comment has been minimized.

Copy link
Author

commented Jun 10, 2018

(completely fixed, I guess)

@Alkarex

This comment has been minimized.

Copy link
Member

commented Jun 10, 2018

Looks better 👍
For reference:

With the theme Origine:

image

With the theme Pafat:

image

@PhieF

This comment has been minimized.

Copy link
Author

commented Jun 14, 2018

strange for the second one, but still usable, I think forcing the icon to the left can be dangerous

@PhieF

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

Two more commits : a fix on scrolling with the "mobile ui"

and a suggestion: on mobile, focus on article content when selecting a title, what to you think ?

@Alkarex Alkarex modified the milestones: 1.12.0, 1.13.0 Oct 14, 2018

@Frenzie

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

@PhieF

and a suggestion: on mobile, focus on article content when selecting a title, what to you think ?

How do you mean precisely?

@Alkarex

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Sorry for the delay on this PR. When I tested it, there were a few problems such as slight performance issues, and I got sidetracked. Let's come back to it after #2117

@Alkarex Alkarex modified the milestones: 1.13.0, 1.14.0 Dec 16, 2018

@Alkarex Alkarex modified the milestones: 1.13.1, 1.14.0 Dec 27, 2018

@Alkarex Alkarex modified the milestones: 1.14.0, 1.15.0 Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.