Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header to cli #2296

Merged
merged 2 commits into from Mar 23, 2019

Conversation

Projects
None yet
2 participants
@aledeg
Copy link
Contributor

commented Mar 23, 2019

Now there is a switch to display the header on user info.
While doing that, I've changed how the command is working to display
all users by default and to accept more than one user at once.
I also changed the display to make it more pleasing.

As this command displays all users by default. I wonder if we still
need the list user command.

See #2294

@Alkarex Alkarex added this to the 1.14.0 milestone Mar 23, 2019

@@ -170,7 +170,7 @@ function format_bytes($bytes, $precision = 2, $system = 'IEC') {
$pow = $bytes === 0 ? 0 : floor(log($bytes) / log($base));
$pow = min($pow, count($units) - 1);
$bytes /= pow($base, $pow);
return format_number($bytes, $precision) . ' ' . $units[$pow];
return format_number($bytes, $precision) . ' ' . $units[$pow];

This comment has been minimized.

Copy link
@aledeg

aledeg Mar 23, 2019

Author Contributor

I've changed this space because it wasn't a regular space. I don't know if it was on purpose or not. The space was coded on two bytes and broke the cli display layout.

This comment has been minimized.

Copy link
@Alkarex

Alkarex Mar 23, 2019

Member

It was on purpose, but if it broke anything, it is not a problem to remove it

This comment has been minimized.

Copy link
@aledeg

aledeg Mar 23, 2019

Author Contributor

What was the use case which needed such space?

This comment has been minimized.

Copy link
@Alkarex

Alkarex Mar 23, 2019

Member

thin non-breaking space, if I remember correctly, which is the typographic standard between a number and its unit.

Add header to cli
Now there is a switch to display the header on user info.
While doing that, I've changed how the command is working to display
all users by default and to accept more than one user at once.
I also changed the display to make it more pleasing.

As this command displays all users by default. I wonder if we still
need the list user command.

See #2294

@aledeg aledeg force-pushed the aledeg:feature/cli-headers branch from dd959b1 to 732cc37 Mar 23, 2019

@Alkarex Alkarex merged commit f292559 into FreshRSS:dev Mar 23, 2019

3 checks passed

ci/dockercloud (/Docker/Dockerfile) Your tests passed in Docker Cloud
Details
ci/dockercloud (/Docker/Dockerfile-Alpine) Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Alkarex added a commit that referenced this pull request Mar 23, 2019

@Alkarex Alkarex referenced this pull request Mar 23, 2019

Merged

FreshRSS 1.14.0 #2298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.