Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a language reference while adding a new one #3044

Merged
merged 1 commit into from Jun 10, 2020

Conversation

aledeg
Copy link
Member

@aledeg aledeg commented Jun 8, 2020

Changes proposed in this pull request:

  • Add a language reference while adding a new one

How to test the feature manually:

  1. Create a new language from a different reference than English
  2. Check that created files are not containing English translations

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

See #3041

Before, all new languages were generated from the reference language which
was English. It makes sense for new languages but not so much for new language
flavor (ex: French Canadian versus French French)
Now, there is a way to select the reference language while adding a new one.
@aledeg aledeg added the I18n 🌍 Translations label Jun 8, 2020
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alkarex Alkarex added this to the 1.17.0 milestone Jun 10, 2020
@Alkarex Alkarex merged commit 7f76c8e into FreshRSS:master Jun 10, 2020
@aledeg aledeg deleted the feature/select-language-reference branch June 11, 2020 03:34
@Alkarex Alkarex modified the milestones: 1.17.0, 1.16.3 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n 🌍 Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants