Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable shortcuts #3114

Merged
merged 1 commit into from Jul 14, 2020

Conversation

aledeg
Copy link
Member

@aledeg aledeg commented Jul 14, 2020

Closes #3110

Changes proposed in this pull request:

  • Add a way to disable shortcuts

How to test the feature manually:

  1. Change a shortcut value to an empty value and save.
  2. Try to use the shortcut.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

When the user do not want to use a shortcut, he can let the shortcut value
empty. This will save an empty configuration thus disabling the shortcut.
The load default action allows to use default shortcut only for disabled
shortcuts.

When the user do not want to use a shortcut, he can let the shortcut value
empty. This will save an empty configuration thus disabling the shortcut.
The load default action allows to use default shortcut only for disabled
shortcuts.

See FreshRSS#3110
@aledeg aledeg force-pushed the feature/disable-shortcuts branch from fbaa763 to 6559b20 Compare July 14, 2020 08:46
@aledeg aledeg added the UI 🎨 User Interfaces label Jul 14, 2020
@aledeg aledeg added this to the 1.17.0 milestone Jul 14, 2020
@Alkarex Alkarex merged commit 35eed83 into FreshRSS:master Jul 14, 2020
@aledeg aledeg deleted the feature/disable-shortcuts branch July 14, 2020 09:06
@Alkarex Alkarex modified the milestones: 1.17.0, 1.16.3 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQ: Allow disabling keyboard shortcuts
2 participants